524175 - Weight calculation wrong for selectors involving pseudo-elements

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Attachment: Testcase

This is a regression from bug 520848, pointed out in bug 508466 comment 17.  Testcase attached.

The key issue is the removal of the weight += listSel->CalcWeight() call in the old !IsSinglePseudoClass(*listSel) branch under (!nsCSSPseudoClasses::IsPseudoClass(pseudoClassList->mAtom)).

Comment 1

[Boris Zbarsky [:bzbarsky]]

Oh, and we're no longer dropping rules with multiple pseudo-elements, though at least I suspect we're not matching them...

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix

Comment 3

[Zack Weinberg (:zwol)]

Comment on attachment 408089 [details] [diff] [review]
Fix

Looks good.

CSS2.1 does say that pseudo-elements contribute to the 'd' component of the specificity (== the low byte of the weight) but I cannot presently think of a situation where it matters, and maybe that should be a follow-up bug.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Yeah, I can't think of a situation where it matters either, until we support selectors with more than one pseudo-element in them.  And even then it might not.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Pushed http://hg.mozilla.org/mozilla-central/rev/cfe85c2bbc53