524219 - Renaming a tag in the Library doesn't show its new name until the Library gets reopened

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2b1) Gecko/20091014 Firefox/3.6b1

Renaming a tag inside the Library doesn't update its name until the Library is reopened.

Steps:
1. Open the Library
2. Select any bookmark and add the tag "test"
3. Expand the tags container and select the tag "test"
4. Change its name
5. Click somewhere outside of the textbox 

After step 5 the tag still shows its old name.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Oh, and that happens on all platforms for me.

Comment 2

[Marcia Knous [:marcia]]

I am not able to reproduce this using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2b1) Gecko/20091019 Firefox/3.6b1 - Henrik it looks as if you are using the first beta build - can you try the second build?

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

It doesn't matter. The same happens in todays nightly too.

Comment 4

[Marco Bonardo [:mak]]

i suppose could be a regression from bug 498130.

We should check the builds before and after it landed.

Comment 5

[(mostly gone) XtC4UaLL [:xtc4uall]]

Marco, you're right.
this regressed within
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e109f9a3b6ee&tochange=149c3820e8a8
(i only have hourly builds before/after the 1st landing of that patch, but that shouldn't matter).

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #5)
> Marco, you're right.
> this regressed within
> http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e109f9a3b6ee&tochange=149c3820e8a8

The patch has been written by Asaf. Lets cc him. Thanks for checking the range.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Mano, can you fix?

Comment 8

[Asaf Romano (gone)]

Attachment: patch

Comment 9

[Marco Bonardo [:mak]]

Comment on attachment 408699 [details] [diff] [review]
patch

>diff --git a/toolkit/components/places/tests/unit/test_419731.js b/toolkit/components/places/tests/unit/test_419731.js

>-  root.containerOpen = false;
>+  theTag.containerOpen = false;

nit: close root

Thanks!

Comment 10

[Asaf Romano (gone)]

mc: 448f4866de46
192: b5ce20227bab

Comment 11

[Marco Bonardo [:mak]]

b1 has already a separate branch so this is final-fixed
thanks.

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed on trunk and 1.9.2 with builds on OS X:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.3a1pre) Gecko/20091101 Minefield/3.7a1pre ID:20091101031119

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2b2pre) Gecko/20091030 Namoroka/3.6b2pre ID:20091030043032