524407 - Prefs UI changes history_expire_days_min but not history_expire_days

Status: RESOLVED WONTFIX

(Toolkit :: Places, defect)

Description

[Justin Dolske [:Dolske]]

If you go into the prefs dialog and change the "Remember my browsing history for at least X days" value, the browser.history_expire_days_min value is updated but browser.history_expire_days is not.

history_expire_days defaults to 180, so if the user tries to remember, say, 200 days of history through the UI, we end up in the odd state of having:

history_expire_days_min == 200
history_expire_days     == 180

I wonder what Places does when that happens.

We should probably have the prefs UI set history_expire_days to history_expire_days_min + 90 or somesuch, so the prefs make sense. (I think these prefs are supposed to get merged at somepoint, but this should be a safe intermediate fix).

Comment 1

[Marco Bonardo [:mak]]

(In reply to comment #0)
> If you go into the prefs dialog and change the "Remember my browsing history
> for at least X days" value, the browser.history_expire_days_min value is
> updated but browser.history_expire_days is not.

this is by design

> history_expire_days defaults to 180, so if the user tries to remember, say, 200
> days of history through the UI, we end up in the odd state of having:
> 
> history_expire_days_min == 200
> history_expire_days     == 180
> I wonder what Places does when that happens.

then we retain 200 days, we preserve user's will

> We should probably have the prefs UI set history_expire_days to
> history_expire_days_min + 90 or somesuch, so the prefs make sense.

We don't want, since there is no point in doing that (we satisfy the user in both cases as i explained before). The lazy limit (expire_days) is there just for some crazy try to avoid bloating the db in the default case.

btw, all of this is going to be rewritten in this project: https://wiki.mozilla.org/Firefox/Projects/Places_async_expiration
And all current expiration prefs will probably just become obsolete (see the discussion in the newsgroup). We will just remove any time constraint, and calculate a limit based on available hardware informations.

Comment 2

[Marco Bonardo [:mak]]

wontfix for comment 1