Last Comment Bug 524442 - startDocumentLoad and endDocumentLoad URIs don't match
: startDocumentLoad and endDocumentLoad URIs don't match
Status: RESOLVED FIXED
: fixed-seamonkey2.0.1
Product: SeaMonkey
Classification: Client Software
Component: UI Design (show other bugs)
: Trunk
: All All
: -- normal (vote)
: ---
Assigned To: neil@parkwaycc.co.uk
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-10-26 04:07 PDT by neil@parkwaycc.co.uk
Modified: 2009-10-27 17:07 PDT (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Proposed patch (623 bytes, patch)
2009-10-26 04:09 PDT, neil@parkwaycc.co.uk
iann_bugzilla: review+
iann_bugzilla: approval‑seamonkey2.0.1+
Details | Diff | Review

Description neil@parkwaycc.co.uk 2009-10-26 04:07:25 PDT
Bug 18423 was apparently responsible for revision 1.43 of nsBrowserInstance.cpp which was the first time that EndDocumentLoad started using the channel's originalURI. Nobody thought to change StartDocumetnLoad to match, and this distinction has been propagated down the line in such bugs as 46200 (which moved the code from C++ to JS). However this causes a problem when restoring or opening a tab or window with a redirected URL such as an about: URL; in this case the underlying URL temporarily flashes up in the URL bar until the location change notification updates it with the correct URL.
Comment 1 neil@parkwaycc.co.uk 2009-10-26 04:09:07 PDT
Created attachment 408354 [details] [diff] [review]
Proposed patch
Comment 2 neil@parkwaycc.co.uk 2009-10-27 17:07:04 PDT
Pushed changeset 3643ca91a6c6 to comm-central.

Pushed changeset ca65c3600243 to releases/comm-1.9.1

Note You need to log in before you can comment on or make changes to this bug.