8.43 KB, patch
Smokey Ardisson (offline for a while; not following bugs - do not email): review+
|Details | Diff | Splinter Review|
320 bytes, patch
|Details | Diff | Splinter Review|
460 bytes, text/plain
Stuart and I were discussing pushing 2.0RC1 via software update in order to make sure we get plenty of testing (and not relying on just the forum thread). We didn't do this for 1.6, but we also didn't land 9 bugs in the last week before the RC, either ;-) We'd want a different update description for this, to keep news media from thinking it is Camino 2.0 and so forth.
Intl = 0 keeps us from sending this to any localized 2.0b4s in the wild, right? (We really should document the formats on the wiki so I can just refer there instead of asking the same question over and over again ;) )
Well, it depends on whether they set general.useragent.extra.multilang to something in the build; just having a localization isn't enough. If that's set, then yes.
Hrm, so no.
But the same issue arises when 2.0 really gets pushed, so it shouldn't really affect the decision to do the early push or not.
Right; it just means I need to give l10n the heads up, which I didn't get to last night :(
I suppose in our update description we could mention that this is English-only, along with the other qualifications about the RC.
Created attachment 408631 [details] [diff] [review] Update script tweak This adds update script support for "rc" as a suffix like "a1" or "b", so that we can mark an update as being an rc (in the update definition) in order to cause it to only go to our non-stable-release users. We could just use MinCaminoVersionString = 2.0a1pre instead but I think we want to get 10.4+ users of 1.6-based nightlies up to the RC.
Created attachment 408667 [details] [diff] [review] Update script v2 [landed] Per IRC discussion, this script has gotten pretty hard to understand as I've wedged extra logic in over time. This does a bunch of refactoring that should make it much easier to follow (but functionally is still just adding 'rc' as a supported suffix for update descriptions).
Comment on attachment 408667 [details] [diff] [review] Update script v2 [landed] r=ardissone; it's much easier to follow what's supposed to be going on.
Comment on attachment 408667 [details] [diff] [review] Update script v2 [landed] Landed it (on CVS trunk and CAMINO_2_0_BRANCH for simplicity) with a couple typo fixes from Smokey.
Created attachment 408702 [details] [diff] [review] Update definition This should be a correct update definition, but I think I always get *something* wrong ;) We'll need a description to go with it, and then to put the whole mess up on staging and make extra sure it does the right thing with both 2.0<foo> and 1.6.10.
<p>Camino 2.0 Release Candidate 1 is the final preview of what will become Camino 2. The goal of this release candidate is to ensure no critical problems remain before the final release. If no problems are found, this version will become Camino 2 and there will be no additional update necessary to obtain Camino 2.</p> <p>Camino 2.0 Release Candidate 1 is available only in English.</p>
s/become/be released as/? "Become" might imply an update would happen. Similarly, I would axe the last "to obtain Camino 2". Maybe add ", however a localized version will be available at the time of the final 2.0 release"?
And we're live, with Stuart's changes to the description and some others from irc. Giving this bug to Stuart because his changes for the script are the patches here and they're really what enabled this brave new world. :)
Created attachment 408754 [details] Update description Just for posterity, better to have this here than not.