Closed Bug 52464 Opened 24 years ago Closed 23 years ago

Polish (po): right alt-l opens bookmarks, right alt-n opens debug menus

Categories

(Core :: DOM: UI Events & Focus Handling, defect, P2)

Product:
Core
Component:
DOM: UI Events & Focus Handling
Platform:
x86
Windows 98
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.2

People

(Reporter: aleksander.adamowski, Assigned: tetsuroy)

References

Details

(Keywords: intl, Whiteboard: checked-in)

Attachments

(3 files)

Remove type case
874 bytes, patch
Details | Diff | Splinter Review
here's some updated string-fu ... is the |nsAutoString| appropriate for this use? if so, use this
1.21 KB, patch
Details | Diff | Splinter Review
correcting syntax error: missing '{'
1.26 KB, patch
Details | Diff | Splinter Review 
I'm using Mozilla on a POlish version of Win98.
when in the browser (I'm using recent win32-talkback nightly build from
ftp.mozilla.org) combinations of right ALT key and the letters "l" or "n" pull
down correspondingly the "bookmakrs" menu or the "debug" menu.
It's very annoying when filling forms because these 2 combinations are used for
Polish diacritical characters (that are similar in appearance to latin L and N).
Polish keyboard layout uses combinations of right ALT and alpha chars for Polish
diacritical chars.
The bug happens only when using right ALT, behaviour of the left ALT is
unchanged (does nothing).
teruko, do you see this?
Component: XP Apps → Keyboard Navigation
QA Contact: sairuh → teruko
Reporter: is this still occuring in the latest builds?

Yes, it still occurs in 2000101120-mtrunk mozilla-win32-talkback.
Moving to New as per responders comments.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Since Don has left, Vishy is taking his bugs in bulk, pending reassignment.
thanks,
	Vishy
Assignee: don → vishy
Keywords: intl
This is key event issue. Move to ftang for now.
Assignee: vishy → ftang
polish in summary
Summary: right alt-l opens bookmarks, right alt-n opens debug menus → Polish (po): right alt-l opens bookmarks, right alt-n opens debug menus
Mark this as P2 and moz0.9. Key issue. Reassign to yokoyama@netscape.com and cc
brade@netscape.com, hyatt@netscape.com and mjudge@netscape.c on this.
This is strange since it is ALTGR + l (I cannot reproduce the ALTGR + n case in
my NT4) for the bookmark which should only active when ALT + "b" . I don't
understand why it is not ALTGR + b invoke that but ALTGR + n or l.
Mid priority since this is important for user in normal usage in their language.
We probably do something wrong in mozilla/widget/src/windows/nsWindows.cpp
yokoyama, please install "Polish" keyboard layout into your window system and
try to reproduce it. Debug it and find me if you need some help.
Assignee: ftang → yokoyama
Priority: P3 → P2
Target Milestone: --- → mozilla0.9
Status: NEW → ASSIGNED
Target Milestone: mozilla0.9 → ---
Changed QA contact to andreasb@netscape.com.
QA Contact: teruko → andreasb
Target Milestone: --- → mozilla1.0
*** Bug 73925 has been marked as a duplicate of this bug. ***
Target Milestone: mozilla1.0 → Future
Changing the milestone to 0.9.2 and verifed that <right ALT>+'n' brings
down the Debug menu as well as <right ALT>+'l' for bookmark.
Target Milestone: Future → mozilla0.9.2
I belive I have a fix for this.

There is a type cast from Unicode char to char which causes to loose
the first byte of unicode char.
I'll post a patch in a minute.
Attached patch Remove type case — — Splinter Review 

    
    

    
  
scc: Thanks for your recommendation. Please /sr= ?
ftang: please /r= ?


    
  
Whiteboard: waiting for /r=

    
    

    
  
sr=scc

    
  
Whiteboard: waiting for /r= → got /r=ftang and /sr=scc. waiting for /a=

    
    

    
  
a=blizzard for the trunk

    
  
Blocks: 83989

    
  
Whiteboard: got /r=ftang and /sr=scc. waiting for /a= → Ready to check-in.  Waiting for tree opening.

    
    

    
  
r=ftang
roy- check it in.
Whiteboard: Ready to check-in.  Waiting for tree opening. → r=ftang, sr=scc, a=blizzard Ready to check-in.  Waiting for tree opening.

    
    

    
  
checked-in
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Whiteboard: r=ftang, sr=scc, a=blizzard Ready to check-in.  Waiting for tree opening. → checked-in

    
    

    
  
Reporter, can you give it a try on the latest build and see if it works for you
now.  

Changing QA contact to marina@netscape.com for now, Marina, do you have a way to
verify this bug?
QA Contact: andreasb → marina

    
    

    
  
Roy, i am putting comments here for the record of what we've seen on my machine:
the problem still exists in the current build (2001-06-07), re-open??

    
    

    
  
i am reopening
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
    

    
  
I verified that this is FIXED in 2001060620 on win2k and Linux, and on
2001060720 on win2k. No need to check further...
If there are other problems, they are unrelated and a separate bug has to be filed.
Thanks guys, that fix is very exciting for me, it was a really annoying bug!
Status: REOPENED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED

    
    

    
  
fix went into 2006-07 branch build and then was checked into trunk, verifying as
fixed now
Status: RESOLVED → VERIFIED
Component: Keyboard: Navigation → User events and focus handling

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: