52464 - Polish (po): right alt-l opens bookmarks, right alt-n opens debug menus

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P2)

Description

[Aleksander Adamowski]

I'm using Mozilla on a POlish version of Win98.
when in the browser (I'm using recent win32-talkback nightly build from
ftp.mozilla.org) combinations of right ALT key and the letters "l" or "n" pull
down correspondingly the "bookmakrs" menu or the "debug" menu.
It's very annoying when filling forms because these 2 combinations are used for
Polish diacritical characters (that are similar in appearance to latin L and N).
Polish keyboard layout uses combinations of right ALT and alpha chars for Polish
diacritical chars.
The bug happens only when using right ALT, behaviour of the left ALT is
unchanged (does nothing).

Comment 1

[sairuh (rarely reading bugmail)]

teruko, do you see this?

Comment 2

[Keyser Sose]

Reporter: is this still occuring in the latest builds?

Comment 3

[Aleksander Adamowski]

Yes, it still occurs in 2000101120-mtrunk mozilla-win32-talkback.

Comment 4

[Keyser Sose]

Moving to New as per responders comments.

Comment 5

[Viswanath Ramachandran]

Since Don has left, Vishy is taking his bugs in bulk, pending reassignment.
thanks,
	Vishy

Comment 6

[Frank Tang]

This is key event issue. Move to ftang for now.

Comment 7

[Chris McAfee]

polish in summary

Comment 8

[Frank Tang]

Mark this as P2 and moz0.9. Key issue. Reassign to [e-mail] and cc
[e-mail], [e-mail] and mjudge@netscape.c on this.
This is strange since it is ALTGR + l (I cannot reproduce the ALTGR + n case in
my NT4) for the bookmark which should only active when ALT + "b" . I don't
understand why it is not ALTGR + b invoke that but ALTGR + n or l.
Mid priority since this is important for user in normal usage in their language.
We probably do something wrong in mozilla/widget/src/windows/nsWindows.cpp
yokoyama, please install "Polish" keyboard layout into your window system and
try to reproduce it. Debug it and find me if you need some help.

Comment 9

[Teruko Kobayashi]

Changed QA contact to [e-mail].

Comment 10

[Keyser Sose]

*** Bug 73925 has been marked as a duplicate of this bug. ***

Comment 11

[Roy Yokoyama]

Changing the milestone to 0.9.2 and verifed that <right ALT>+'n' brings
down the Debug menu as well as <right ALT>+'l' for bookmark. 

Comment 12

[Roy Yokoyama]

I belive I have a fix for this.

There is a type cast from Unicode char to char which causes to loose
the first byte of unicode char.
I'll post a patch in a minute.

Comment 13

[Roy Yokoyama]

Attachment: Remove type case

Comment 14

[Scott Collins]

Attachment: here's some updated string-fu ... is the |nsAutoString| appropriate for this use? if so, use this

Comment 15

[Roy Yokoyama]

Attachment: correcting syntax error: missing '{'

Comment 16

[Roy Yokoyama]

scc: Thanks for your recommendation. Please /sr= ?
ftang: please /r= ?

Comment 17

[Scott Collins]

sr=scc

Comment 18

[Christopher Blizzard (:blizzard)]

a=blizzard for the trunk

Comment 19

[Frank Tang]

r=ftang
roy- check it in.

Comment 20

[Roy Yokoyama]

checked-in

Comment 21

[Andreas Becker]

Reporter, can you give it a try on the latest build and see if it works for you
now.  

Changing QA contact to [e-mail] for now, Marina, do you have a way to
verify this bug?

Comment 22

[marina]

Roy, i am putting comments here for the record of what we've seen on my machine:
the problem still exists in the current build (2001-06-07), re-open??

Comment 23

[marina]

i am reopening

Comment 24

[Aleksander Adamowski]

I verified that this is FIXED in 2001060620 on win2k and Linux, and on
2001060720 on win2k. No need to check further...
If there are other problems, they are unrelated and a separate bug has to be filed.
Thanks guys, that fix is very exciting for me, it was a really annoying bug!

Comment 25

[marina]

fix went into 2006-07 branch build and then was checked into trunk, verifying as
fixed now