If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Use nsTArray<nsRefPtr<nsAccEvent> > for mEventsToFire

RESOLVED FIXED

Status

()

Core
Disability Access APIs
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Ginn Chen, Assigned: Ginn Chen)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

7.79 KB, patch
surkov
: review+
Details | Diff | Splinter Review
(Assignee)

Description

8 years ago
See Bug 522847 comment 2
(Assignee)

Comment 1

8 years ago
Created attachment 408620 [details] [diff] [review]
patch

Addressed Bug 522847 comment 11

BTW: Do we have to have so many QueryAccessible* in nsAccUtils.h?
Why not just use QueryObject template?
Assignee: nobody → ginn.chen
Status: NEW → ASSIGNED
Attachment #408620 - Flags: review?(surkov.alexander)
Why not use nsTArray< nsRefPtr<nsAccEvent> >?

Comment 3

8 years ago
(In reply to comment #1)

> BTW: Do we have to have so many QueryAccessible* in nsAccUtils.h?
> Why not just use QueryObject template?

QueryObject was created later than all of this QueryAccessible*

Comment 4

8 years ago
Ginn, could you use diff -p to include function names and answer Boris's comment?
(Assignee)

Comment 5

8 years ago
Created attachment 408805 [details] [diff] [review]
patch v2

Use nsTArray<nsRefPtr<nsAccEvent> > for mEventsToFire, and use nsAccEvent* in nsAccessibleEventData.cpp for performance.
Attachment #408620 - Attachment is obsolete: true
Attachment #408805 - Flags: review?(surkov.alexander)
Attachment #408620 - Flags: review?(surkov.alexander)

Updated

8 years ago
Attachment #408805 - Flags: review?(surkov.alexander) → review+

Comment 6

8 years ago
Comment on attachment 408805 [details] [diff] [review]
patch v2

looks ok, r=me
sr from bz?
Comment on attachment 408805 [details] [diff] [review]
patch v2

I don't think you need the "// AddRefs" comment.  Other than that, looks good.
Attachment #408805 - Flags: superreview+
(Assignee)

Comment 8

8 years ago
http://hg.mozilla.org/mozilla-central/rev/dbd01b91903a
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Summary: Use nsTArray<nsAccEvent *> for mEventsToFire → Use nsTArray<nsRefPtr<nsAccEvent> > for mEventsToFire
You need to log in before you can comment on or make changes to this bug.