Closed
Bug 524696
Opened 15 years ago
Closed 15 years ago
Use nsTArray<nsRefPtr<nsAccEvent> > for mEventsToFire
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
People
(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)
References
Details
Attachments
(1 file, 1 obsolete file)
|
7.79 KB,
patch
|
surkov
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
Addressed Bug 522847 comment 11
BTW: Do we have to have so many QueryAccessible* in nsAccUtils.h?
Why not just use QueryObject template?
Assignee: nobody → ginn.chen
Status: NEW → ASSIGNED
Attachment #408620 -
Flags: review?(surkov.alexander)
|
||
Comment 2•15 years ago
|
||
Why not use nsTArray< nsRefPtr<nsAccEvent> >?
|
||
Comment 3•15 years ago
|
||
(In reply to comment #1)
> BTW: Do we have to have so many QueryAccessible* in nsAccUtils.h?
> Why not just use QueryObject template?
QueryObject was created later than all of this QueryAccessible*
|
|
||
Comment 4•15 years ago
|
||
Ginn, could you use diff -p to include function names and answer Boris's comment?
Use nsTArray<nsRefPtr<nsAccEvent> > for mEventsToFire, and use nsAccEvent* in nsAccessibleEventData.cpp for performance.
Attachment #408620 -
Attachment is obsolete: true
Attachment #408805 -
Flags: review?(surkov.alexander)
Attachment #408620 -
Flags: review?(surkov.alexander)
|
|
||
Updated•15 years ago
|
Attachment #408805 -
Flags: review?(surkov.alexander) → review+
|
|
||
Comment 6•15 years ago
|
||
Comment on attachment 408805 [details] [diff] [review]
patch v2
looks ok, r=me
sr from bz?
|
|
||
Comment 7•15 years ago
|
||
Comment on attachment 408805 [details] [diff] [review]
patch v2
I don't think you need the "// AddRefs" comment. Other than that, looks good.
Attachment #408805 -
Flags: superreview+
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Summary: Use nsTArray<nsAccEvent *> for mEventsToFire → Use nsTArray<nsRefPtr<nsAccEvent> > for mEventsToFire
You need to log in
before you can comment on or make changes to this bug.
Description
•