Last Comment Bug 524732 - jsreftests - js1_5/Regress/regress-344804.js | js1_5/Scope/regress-181834.js FAIL
: jsreftests - js1_5/Regress/regress-344804.js | js1_5/Scope/regress-181834.js ...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: x86 Windows XP
: -- normal (vote)
: mozilla11
Assigned To: Ryan VanderMeulen [:RyanVM]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-10-27 11:44 PDT by Bob Clary [:bc:]
Modified: 2011-11-29 04:58 PST (History)
4 users (show)
bob: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch to reenable tests (1.60 KB, patch)
2009-12-14 13:25 PST, Bob Clary [:bc:]
benjamin: review+
Details | Diff | Splinter Review
Updated patch (1.52 KB, patch)
2011-11-27 18:18 PST, Ryan VanderMeulen [:RyanVM]
bob: review+
Details | Diff | Splinter Review

Description Bob Clary [:bc:] 2009-10-27 11:44:21 PDT
jsreftests - js1_5/Regress/regress-344804.js | js1_5/Scope/regress-181834.js are failing on Windows with Attempt to call default method on object with no default method.
Comment 1 Bob Clary [:bc:] 2009-10-27 21:23:51 PDT
http://hg.mozilla.org/tracemonkey/rev/930e7e7e9217
mark as failing for windows browser. This is not reproducible in my local vm.
Comment 2 Bob Clary [:bc:] 2009-11-19 11:25:29 PST
jorendorff: do you have any idea why this would fail on the unit test machines but not locally?
Comment 3 Bob Clary [:bc:] 2009-12-14 13:25:39 PST
Created attachment 417548 [details] [diff] [review]
patch to reenable tests
Comment 4 Benjamin Smedberg [:bsmedberg] 2009-12-14 13:29:34 PST
Comment on attachment 417548 [details] [diff] [review]
patch to reenable tests

ok, let's try it, and we can at least move back to random-if if we've just made it intermittent
Comment 5 Benjamin Smedberg [:bsmedberg] 2009-12-16 13:16:33 PST
reverted to random-if because of failures reappearing today: http://hg.mozilla.org/mozilla-central/rev/3b4baf256382
Comment 6 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2010-05-04 17:10:02 PDT
In these two tests (and no other tests in jsreftest), we also hit the assertion:

###!!! ASSERTION: Shouldn't ever call this directly!: 'Not Reached', file e:/builds/moz2_slave/mozilla-central-win32-debug/build/dom/plugins/PluginScriptableObjectParent.cpp, line 327

They hit the assertion every time in Windows debug builds, and they also seem to be failing every time.
Comment 7 Ryan VanderMeulen [:RyanVM] 2011-11-27 14:20:23 PST
They pass locally. Going to push a patch to try to see what happens if I re-enable them for all platforms.

js/src/tests/js1_5/Regress/regress-344804.js
BUGNUMBER: 344804
STATUS: Do not crash iterating over window.Packages
 PASSED! Do not crash iterating over window.Packages

js/src/tests/js1_5/Scope/regress-181834.js
BUGNUMBER: 181834
STATUS: Testing scope
 PASSED! Section 1 of test -
 PASSED! Section 2 of test -
 PASSED! Section 3 of test -
 PASSED! Section 4 of test -
 PASSED! Section 5 of test -
 PASSED! Section 6 of test -
Comment 8 Ryan VanderMeulen [:RyanVM] 2011-11-27 18:18:09 PST
Created attachment 577177 [details] [diff] [review]
Updated patch

Try likes it too. I had multiple runs triggered and all completed without issue.
https://tbpl.mozilla.org/?tree=Try&rev=bb9dd1ff3610
Comment 9 Bob Clary [:bc:] 2011-11-28 03:04:53 PST
Comment on attachment 577177 [details] [diff] [review]
Updated patch

Review of attachment 577177 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks. Can you get one of the JS team to piggy back this patch during a landing?
Comment 10 Daniel Holbert [:dholbert] 2011-11-28 15:02:07 PST
Landed:
 https://hg.mozilla.org/integration/mozilla-inbound/rev/8dd8c2258cc2
Comment 11 Marco Bonardo [::mak] 2011-11-29 04:58:29 PST
https://hg.mozilla.org/mozilla-central/rev/8dd8c2258cc2

Note You need to log in before you can comment on or make changes to this bug.