Closed
Bug 524732
Opened 15 years ago
Closed 13 years ago
jsreftests - js1_5/Regress/regress-344804.js | js1_5/Scope/regress-181834.js FAIL
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla11
People
(Reporter: bc, Assigned: RyanVM)
Details
Attachments
(1 file, 1 obsolete file)
1.52 KB,
patch
|
bc
:
review+
|
Details | Diff | Splinter Review |
jsreftests - js1_5/Regress/regress-344804.js | js1_5/Scope/regress-181834.js are failing on Windows with Attempt to call default method on object with no default method.
Flags: in-testsuite-
Reporter | ||
Comment 1•15 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/930e7e7e9217 mark as failing for windows browser. This is not reproducible in my local vm.
Reporter | ||
Comment 2•15 years ago
|
||
jorendorff: do you have any idea why this would fail on the unit test machines but not locally?
Reporter | ||
Comment 3•15 years ago
|
||
Comment 4•15 years ago
|
||
Comment on attachment 417548 [details] [diff] [review] patch to reenable tests ok, let's try it, and we can at least move back to random-if if we've just made it intermittent
Attachment #417548 -
Flags: review+
Comment 5•15 years ago
|
||
reverted to random-if because of failures reappearing today: http://hg.mozilla.org/mozilla-central/rev/3b4baf256382
In these two tests (and no other tests in jsreftest), we also hit the assertion: ###!!! ASSERTION: Shouldn't ever call this directly!: 'Not Reached', file e:/builds/moz2_slave/mozilla-central-win32-debug/build/dom/plugins/PluginScriptableObjectParent.cpp, line 327 They hit the assertion every time in Windows debug builds, and they also seem to be failing every time.
Assignee | ||
Comment 7•13 years ago
|
||
They pass locally. Going to push a patch to try to see what happens if I re-enable them for all platforms. js/src/tests/js1_5/Regress/regress-344804.js BUGNUMBER: 344804 STATUS: Do not crash iterating over window.Packages PASSED! Do not crash iterating over window.Packages js/src/tests/js1_5/Scope/regress-181834.js BUGNUMBER: 181834 STATUS: Testing scope PASSED! Section 1 of test - PASSED! Section 2 of test - PASSED! Section 3 of test - PASSED! Section 4 of test - PASSED! Section 5 of test - PASSED! Section 6 of test -
Assignee | ||
Comment 8•13 years ago
|
||
Try likes it too. I had multiple runs triggered and all completed without issue. https://tbpl.mozilla.org/?tree=Try&rev=bb9dd1ff3610
Attachment #417548 -
Attachment is obsolete: true
Attachment #577177 -
Flags: review?(bclary)
Reporter | ||
Comment 9•13 years ago
|
||
Comment on attachment 577177 [details] [diff] [review] Updated patch Review of attachment 577177 [details] [diff] [review]: ----------------------------------------------------------------- Thanks. Can you get one of the JS team to piggy back this patch during a landing?
Attachment #577177 -
Flags: review?(bclary) → review+
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Updated•13 years ago
|
Assignee: general → ryanvm
Comment 10•13 years ago
|
||
Landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/8dd8c2258cc2
Keywords: checkin-needed
Target Milestone: --- → mozilla11
Updated•13 years ago
|
Status: NEW → ASSIGNED
Comment 11•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8dd8c2258cc2
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•