Closed Bug 524750 Opened 15 years ago Closed 6 years ago

Move method implementations out of header files and into -inline.h files

Categories

(Tamarin Graveyard :: Virtual Machine, enhancement)

Product:
Tamarin Graveyard
Component:
Virtual Machine
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX
Milestone:
Future

People

(Reporter: edwsmith, Unassigned)

References

Details

Attachments

(11 obsolete files)

This avoids worrying about the order the header files are implemented in, and separates implementation from interface. multiple patches can be attached & reviewed here. Close this out when we think we're done.
Attachment #408657 - Flags: superreview?(stejohns)
Attachment #408657 - Flags: superreview?(stejohns) → superreview+
Comment on attachment 408657 [details] [diff] [review] move method bodies from VTable.h to VTable-inlines.h http://hg.mozilla.org/tamarin-redux/rev/c0f60b27a551
Attachment #408657 - Attachment is obsolete: true
Attachment #408831 - Flags: superreview?(stejohns)
Attachment #408831 - Flags: superreview?(stejohns) → superreview+
Comment on attachment 408831 [details] [diff] [review] factor method bodies from AbcEnv.h into AbcEnv-inlines.h pushed http://hg.mozilla.org/tamarin-redux/rev/12c228399a5f
Attachment #408831 - Attachment is obsolete: true
methods from Block, Edge, and CfgWriter aren't hot so they were moved to Verifier.cpp instead of Verifier-inlines.h
Attachment #409093 - Flags: superreview?(stejohns)
Comment on attachment 409093 [details] [diff] [review] Factor method bodies from Verifier.h to Verifier-inlines.h and Verifier.cpp fix typo: "BlocK::Block"
Attachment #409093 - Flags: superreview?(stejohns) → superreview+
Comment on attachment 409093 [details] [diff] [review] Factor method bodies from Verifier.h to Verifier-inlines.h and Verifier.cpp pushed http://hg.mozilla.org/tamarin-redux/rev/41262baaf1d7
Attachment #409093 - Attachment is obsolete: true
I would like to merge FrameState.h completely into Verifier.h but at the moment, FrameState.h has to be included separately from avmplus.h to get the correct header file order: avmplus.h nanojit.h CodegenLIR.h FrameState.h
Attachment #409313 - Flags: review?(stejohns)
Comment on attachment 409313 [details] [diff] [review] Factor FrameState methods out of FrameState.h into FrameState-inlines drive-by int->int32_t cleanup would be good while we're here.
Attachment #409313 - Flags: review?(stejohns) → review+
Comment on attachment 409313 [details] [diff] [review] Factor FrameState methods out of FrameState.h into FrameState-inlines pushed, including int->int32_t cleanup.
Attachment #409313 - Attachment is obsolete: true
Attachment #409690 - Flags: review?(stejohns)
(i'll fix int->int32_t in ScopeChain.* as well)
Attachment #409690 - Flags: review?(stejohns) → review+
Comment on attachment 409690 [details] [diff] [review] move method bodies out of ScopeChain.h pushed http://hg.mozilla.org/tamarin-redux/rev/c90e430a0f35
Attachment #409690 - Attachment is obsolete: true
and: s/int/int32_t, s/uint32/uint32_t
Attachment #409917 - Flags: superreview?(stejohns)
Attachment #409917 - Flags: superreview?(stejohns) → superreview+
Comment on attachment 409917 [details] [diff] [review] Move method bodies out of PoolObject.h pushed http://hg.mozilla.org/tamarin-redux/rev/db0d8e54a7a3
Attachment #409917 - Attachment is obsolete: true
Attachment #412223 - Flags: review?(stejohns)
Attachment #412223 - Flags: review?(stejohns) → review+
Comment on attachment 412223 [details] [diff] [review] move method bodies out of AbcParser.h pushed http://hg.mozilla.org/tamarin-redux/rev/5224ba1a6c17
Attachment #412223 - Attachment is obsolete: true
Attachment #412628 - Flags: review?(stejohns)
Attachment #412628 - Flags: review?(stejohns) → review+
Comment on attachment 412628 [details] [diff] [review] Move method bodies out of Multiname.h pushed http://hg.mozilla.org/tamarin-redux/rev/d49c1a001ab5
Attachment #412628 - Attachment is obsolete: true
A few should be inline and were moved to (new file) Coder-inlines.h. Virtual methods aren't inlineable and so were moved to Coder.cpp Also, one case of uintptr changed to uintptr_t (use C99 types is preferred). Cleaned up whitespace too (added modelines, fixed all tabs, no whitespace at EOL or EOF)
Attachment #412868 - Flags: review?(jodyer)
Attachment #412868 - Flags: review?(jodyer) → review+
Comment on attachment 412868 [details] [diff] [review] move method bodies out of Coder.h pushed http://hg.mozilla.org/tamarin-redux/rev/e5cfab2c3c40
Attachment #412868 - Attachment is obsolete: true
Plus a few isXXX methods were made const that should already have been.
Attachment #413236 - Flags: review?(stejohns)
Comment on attachment 413236 [details] [diff] [review] move method bodies out of MethodEnv.h and MethodInfo.h Smells like a good C99 opportunity...
Attachment #413236 - Flags: review?(stejohns) → review+
Comment on attachment 413236 [details] [diff] [review] move method bodies out of MethodEnv.h and MethodInfo.h pushed http://hg.mozilla.org/tamarin-redux/rev/4a3d1cc19bf9
Attachment #413236 - Attachment is obsolete: true
Attachment #416305 - Flags: superreview?(stejohns)
Comment on attachment 416305 [details] [diff] [review] move typedef Binding to MultinameHashtable.h, move method bodies to -inlines.h Please change inline to REALLY_INLINE
Attachment #416305 - Flags: superreview?(stejohns) → superreview+
Comment on attachment 416305 [details] [diff] [review] move typedef Binding to MultinameHashtable.h, move method bodies to -inlines.h pushed http://hg.mozilla.org/tamarin-redux/rev/0913a6593a9f
Attachment #416305 - Attachment is obsolete: true
Blocks: 537926
Flags: flashplayer-qrb+
Tamarin is a dead project now. Mass WONTFIX.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
Tamarin isn't maintained anymore. WONTFIX remaining bugs.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: