524937 - netError.dtd is not overridden

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Wolfgang Rosenauer [:wolfiR]]

Fennec is currently overriding netErrorApp.dtd with its own netError.dtd.
Fennec's own netError.dtd carries contents from dom's netError.dtd _and_ netErrorApp.dtd but netError.dtd is not overridden.

Not absolutely sure what the intention is but currently it's broken because either
- Fennec's netError.dtd contains strings which are not intended to be used
- Fennec's netError.dtd doesn't override dom's netError.dtd

My guess was that the second is the bug and I'll attach a possible patch for that.

Comment 1

[Wolfgang Rosenauer [:wolfiR]]

Attachment: patch

This just overrides dom's netError.dtd with Fennec's

Comment 2

[Aakash Desai [:aakashd]]

Mark, can you take a look at this?

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Why do we need to override netError.dtd? I thought netErrorApp was sufficient... Can we just remove the unused strings in our netError?

I wonder whether this is related to bug 522980?

Comment 4

[Wolfgang Rosenauer [:wolfiR]]

(In reply to comment #3)
> Why do we need to override netError.dtd? I thought netErrorApp was
> sufficient... Can we just remove the unused strings in our netError?
> 
> I wonder whether this is related to bug 522980?

Don't know where you get bug 522980 from. The blocked bug is 523296

It all depends on what will finally happen with bug 495674.
With the proposed change there we can run into the netOffline error page and therefore we should use a correct one.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #4)
> (In reply to comment #3)
> > Why do we need to override netError.dtd? I thought netErrorApp was
> > sufficient... Can we just remove the unused strings in our netError?
> > 
> > I wonder whether this is related to bug 522980?
> 
> Don't know where you get bug 522980 from. The blocked bug is 523296

Bug 523296 is a symptom of this bug (and bug 495674 exposes it). I was wondering whether bug 522980 was also a symptom.

This doesn't answer my question about whether we actually need to override netError.dtd. Why isn't overridding netErrorApp sufficient?

Comment 6

[Wolfgang Rosenauer [:wolfiR]]

AFAICS netError.xhtml is just using netError.dtd and we want to modify the netOffline strings.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 408826 [details] [diff] [review]
patch

We should remove the netErrorApp.dtd override. That DTD is not used in our case anymore.

I can do that when I land.

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
https://hg.mozilla.org/mobile-browser/rev/b5b9d5880136