Closed Bug 524937 Opened 10 years ago Closed 10 years ago

netError.dtd is not overridden

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
fennec1.0

People

(Reporter: wolfiR, Assigned: wolfiR)

References

Details

Attachments

(1 file)

Fennec is currently overriding netErrorApp.dtd with its own netError.dtd.
Fennec's own netError.dtd carries contents from dom's netError.dtd _and_ netErrorApp.dtd but netError.dtd is not overridden.

Not absolutely sure what the intention is but currently it's broken because either
- Fennec's netError.dtd contains strings which are not intended to be used
- Fennec's netError.dtd doesn't override dom's netError.dtd

My guess was that the second is the bug and I'll attach a possible patch for that.
Attached patch patchSplinter Review
This just overrides dom's netError.dtd with Fennec's
Blocks: 523296
Mark, can you take a look at this?
Why do we need to override netError.dtd? I thought netErrorApp was sufficient... Can we just remove the unused strings in our netError?

I wonder whether this is related to bug 522980?
(In reply to comment #3)
> Why do we need to override netError.dtd? I thought netErrorApp was
> sufficient... Can we just remove the unused strings in our netError?
> 
> I wonder whether this is related to bug 522980?

Don't know where you get bug 522980 from. The blocked bug is 523296

It all depends on what will finally happen with bug 495674.
With the proposed change there we can run into the netOffline error page and therefore we should use a correct one.
(In reply to comment #4)
> (In reply to comment #3)
> > Why do we need to override netError.dtd? I thought netErrorApp was
> > sufficient... Can we just remove the unused strings in our netError?
> > 
> > I wonder whether this is related to bug 522980?
> 
> Don't know where you get bug 522980 from. The blocked bug is 523296

Bug 523296 is a symptom of this bug (and bug 495674 exposes it). I was wondering whether bug 522980 was also a symptom.

This doesn't answer my question about whether we actually need to override netError.dtd. Why isn't overridding netErrorApp sufficient?
AFAICS netError.xhtml is just using netError.dtd and we want to modify the netOffline strings.
Comment on attachment 408826 [details] [diff] [review]
patch

We should remove the netErrorApp.dtd override. That DTD is not used in our case anymore.

I can do that when I land.
Attachment #408826 - Flags: review+
pushed:
https://hg.mozilla.org/mobile-browser/rev/b5b9d5880136
Assignee: nobody → mozilla
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Post-B5
You need to log in before you can comment on or make changes to this bug.