524969 - Various breakpad files missing #include <cstdio>

Status: RESOLVED DUPLICATE of bug 510920

(Toolkit :: Crash Reporting, defect)

Description

[Adam Sampson]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.4) Gecko/20091028 Shiretoko/3.5.4
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.4) Gecko/20091028 Shiretoko/3.5.4

Several of the breakpad source files use things defined in stdio.h, but fail to #include <cstdio>; this results in the version of breakpad included in Firefox 3.5.4 not compiling with GCC 4.4.1.

Reproducible: Always

Steps to Reproduce:
1. Configure Firefox so that breakpad's enabled.
2. Compile.

Actual Results:  
Compilation fails in several places inside toolkit/crashreporter/google-breakpad/src.

Expected Results:  
Compilation suceeds (as it does for the rest of Firefox).

I'll attach a patch.

Comment 1

[Adam Sampson]

Attachment: Add #include <cstdio> where necessary