524986 - While I'm connecting to Weave, "Connect" button is still clickable (and triggers "Exception: could not acquire lock" in Activity Log)

Status: RESOLVED WONTFIX

(Firefox :: Sync, defect)

Description

[Daniel Holbert [:dholbert]]

STEPS TO REPRODUCE:
 0. Start with an already-configured Weave 0.8pre2
 1. Intentionally rate-limit your bandwidth, so that connecting takes at least a few seconds.  (In ubuntu, I'm using 'wondershaper' -- I run 'wondershaper eth0 10 10')
 2. In the Weave preferences pane, click "Connect"
   --> Weave status-bar icon shows my username and starts spinning
   --> BUT, "Connect" button is still clickable
 3. Click "Connect" a few more times
   --> If I examine debug log, I see entries like the following appearing for the extra clicks:
> 2009-10-28 09:23:49     Service.Main         DEBUG      Exception: Could not acquire lock No traceback available

ACTUAL RESULTS: See lines marked with "-->" above
EXPECTED RESULTS: Connect button should be grayed out (or be otherwise disabled somehow, so it doesn't cause exceptions to be logged) while Weave is connecting.

Weave 0.8pre2
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a1pre) Gecko/20091028 Minefield/3.7a1pre

Comment 1

[Daniel Holbert [:dholbert]]

(In reply to comment #0)
>  1. Intentionally rate-limit your bandwidth, so that connecting takes at least
> a few seconds.

Note: the Steps To Reproduce include bandwidth-limiting simply because that's a way to *reliably* reproduce this.  However, I've hit this bug on a number of occasions without any bandwidth-limiting on my end (perhaps when the server was overloaded or something).

Comment 2

[Ragavan S [:rags]]

Can we verify if this is still a problem with the 1.0b1 client?

Comment 3

[Daniel Holbert [:dholbert]]

Yes, this bug affects 1.0b1. I get the same results as described in comment 0 -- the only thing different that there's now a spinning throbber next to the "Connect" button while I'm connecting.

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a1pre) Gecko/20091114 Minefield/3.7a1pre
Weave 1.0b1

Comment 4

[Daniel Holbert [:dholbert]]

Still affects Weave 1.0b3pre1.
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a1pre) Gecko/20091204 Minefield/3.7a1pre

Comment 5

[Mike Connor [:mconnor]]

simple fix: handleConnectCommand needs to disable the button.  all of the login/logout end handlers call updateWeavePrefs, which will re-enable the button.

Comment 6

[Mike Connor [:mconnor]]

We're killing this in bug 590763