524994 - Flatten out wrapper hierarchy

Status: RESOLVED FIXED

(Core :: XPConnect, defect, P2)

Description

[Blake Kaplan (:mrbkap) (inactive, use needinfo)]

Currently, we purposely do things like creating SOWs around SJOWs in order to enforce security properties. This works, but is overly complicated. We should, instead, be able to tell the SJOWs to enforce SOW-like security properties.

Comment 1

[Johnny Stenback (:jst)]

Blocking 1.9.2 as this is required to fix blocker bug 520522.

Comment 2

[Johnny Stenback (:jst)]

Bug 520522 is no longer a blocker, and thus neither is this.

Comment 3

[Blake Kaplan (:mrbkap) (inactive, use needinfo)]

Attachment: Fix on top of patch for bug 533600

Comment 4

[Blake Kaplan (:mrbkap) (inactive, use needinfo)]

Attachment: refreshed

Comment 5

[Johnny Stenback (:jst)]

Comment on attachment 423098 [details] [diff] [review]
refreshed

- In EnsureLegalActivity():

   // Otherwise, we're looking at a non-system file with a handle on an
   // implicit wrapper. This is a bug! Deny access.
-  return ThrowException(NS_ERROR_XPC_SECURITY_MANAGER_VETO, cx);
+  NS_ERROR("Implicit native wrapper in content code");
+#else
+  return JS_TRUE;
+#endif
+
+  // NB: Watch for early returns in the ifdef DEBUG code above.
 }

Does the above not leave us not returning a value at all in debug code?

r=jst with that fixed.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Blake: any progress on getting this fixed on trunk and branch patches together for 1.9.1.9 and 1.9.2.2

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

mrbkap: please see comment 6?

Comment 8

[Blake Kaplan (:mrbkap) (inactive, use needinfo)]

http://hg.mozilla.org/mozilla-central/rev/e99b9fbe916e