Closed Bug 524994 Opened 11 years ago Closed 11 years ago

Flatten out wrapper hierarchy

Categories

(Core :: XPConnect, defect, P2)

x86
macOS
defect

Tracking

()

RESOLVED FIXED
mozilla1.9.2
Tracking Status
status1.9.2 --- wanted
blocking1.9.1 --- needed
status1.9.1 --- wanted

People

(Reporter: mrbkap, Assigned: mrbkap)

References

Details

Attachments

(1 file, 1 obsolete file)

Currently, we purposely do things like creating SOWs around SJOWs in order to enforce security properties. This works, but is overly complicated. We should, instead, be able to tell the SJOWs to enforce SOW-like security properties.
Blocking 1.9.2 as this is required to fix blocker bug 520522.
Flags: blocking1.9.2+
Priority: -- → P2
Target Milestone: --- → mozilla1.9.2
Assignee: nobody → mrbkap
Flags: blocking1.9.0.17+
Bug 520522 is no longer a blocker, and thus neither is this.
Flags: blocking1.9.2+ → blocking1.9.2-
Attached patch refreshedSplinter Review
Attachment #422623 - Attachment is obsolete: true
Attachment #423098 - Flags: review?(jst)
Attachment #422623 - Flags: review?(jst)
Flags: wanted1.9.0.x+
Whiteboard: [needs r=jst]
blocking1.9.1: --- → .9+
Flags: blocking1.9.0.18+ → blocking1.9.0.19+
Comment on attachment 423098 [details] [diff] [review]
refreshed

- In EnsureLegalActivity():

   // Otherwise, we're looking at a non-system file with a handle on an
   // implicit wrapper. This is a bug! Deny access.
-  return ThrowException(NS_ERROR_XPC_SECURITY_MANAGER_VETO, cx);
+  NS_ERROR("Implicit native wrapper in content code");
+#else
+  return JS_TRUE;
+#endif
+
+  // NB: Watch for early returns in the ifdef DEBUG code above.
 }

Does the above not leave us not returning a value at all in debug code?

r=jst with that fixed.
Attachment #423098 - Flags: review?(jst) → review+
Blake: any progress on getting this fixed on trunk and branch patches together for 1.9.1.9 and 1.9.2.2
Whiteboard: [needs r=jst]
blocking1.9.1: .9+ → needed
Flags: blocking1.9.0.19+ → blocking1.9.0.19-
http://hg.mozilla.org/mozilla-central/rev/e99b9fbe916e
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Depends on: 557127
You need to log in before you can comment on or make changes to this bug.