Closed
Bug 524994
Opened 16 years ago
Closed 15 years ago
Flatten out wrapper hierarchy
Categories
(Core :: XPConnect, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla1.9.2
People
(Reporter: mrbkap, Assigned: mrbkap)
References
Details
Attachments
(1 file, 1 obsolete file)
23.23 KB,
patch
|
jst
:
review+
|
Details | Diff | Splinter Review |
Currently, we purposely do things like creating SOWs around SJOWs in order to enforce security properties. This works, but is overly complicated. We should, instead, be able to tell the SJOWs to enforce SOW-like security properties.
Comment 1•16 years ago
|
||
Blocking 1.9.2 as this is required to fix blocker bug 520522.
Flags: blocking1.9.2+
Priority: -- → P2
Target Milestone: --- → mozilla1.9.2
Updated•16 years ago
|
Assignee: nobody → mrbkap
Updated•16 years ago
|
Flags: blocking1.9.0.17+
Comment 2•16 years ago
|
||
Bug 520522 is no longer a blocker, and thus neither is this.
Flags: blocking1.9.2+ → blocking1.9.2-
Assignee | ||
Comment 3•15 years ago
|
||
Attachment #422623 -
Flags: review?(jst)
Assignee | ||
Comment 4•15 years ago
|
||
Attachment #422623 -
Attachment is obsolete: true
Attachment #423098 -
Flags: review?(jst)
Attachment #422623 -
Flags: review?(jst)
Updated•15 years ago
|
Flags: wanted1.9.0.x+
Whiteboard: [needs r=jst]
Updated•15 years ago
|
blocking1.9.1: --- → .9+
status1.9.1:
--- → wanted
status1.9.2:
--- → wanted
Flags: blocking1.9.0.18+ → blocking1.9.0.19+
Comment 5•15 years ago
|
||
Comment on attachment 423098 [details] [diff] [review]
refreshed
- In EnsureLegalActivity():
// Otherwise, we're looking at a non-system file with a handle on an
// implicit wrapper. This is a bug! Deny access.
- return ThrowException(NS_ERROR_XPC_SECURITY_MANAGER_VETO, cx);
+ NS_ERROR("Implicit native wrapper in content code");
+#else
+ return JS_TRUE;
+#endif
+
+ // NB: Watch for early returns in the ifdef DEBUG code above.
}
Does the above not leave us not returning a value at all in debug code?
r=jst with that fixed.
Attachment #423098 -
Flags: review?(jst) → review+
Comment 6•15 years ago
|
||
Blake: any progress on getting this fixed on trunk and branch patches together for 1.9.1.9 and 1.9.2.2
Updated•15 years ago
|
Whiteboard: [needs r=jst]
Updated•15 years ago
|
blocking1.9.1: .9+ → needed
Flags: blocking1.9.0.19+ → blocking1.9.0.19-
Assignee | ||
Comment 8•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•