525035 - Import button on Open panel for file-based bookmarks import is not localizable

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Use a localizable string

Igor reported that that "Import" button in the Open panel that you get when choosing a file for bookmarks import is not localizable.  Indeed, it's not.

This patch fixes that (with a "ImportPanelButton" key to help keep us from confusing it from the "Import" button in the nib), and it also moves all of the bookmarks import/export/opening localizable strings to be adjacent to each other, rather than in two hunks at opposite ends of the file.

l10n is considering doing this string for 2.0.1 if we do bug 521137, so flagging for 2.0.1 until there's a decision.

Comment 1

[Stuart Morgan]

Comment on attachment 408897 [details] [diff] [review]
Use a localizable string

>+/* Parser error loading bookmarks.xml file */

Change "xml" to "plist" while you are moving this, so it's not years out of date ;)

sr-smorgan otherwise.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Checked in on cvs trunk with "plist".

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #0)
> l10n is considering doing this string for 2.0.1 if we do bug 521137, so
> flagging for 2.0.1 until there's a decision.

Minusing this as a result of the minusing in bug 521137.