Closed Bug 525300 Opened 15 years ago Closed 15 years ago

Make it simpler to test modal dialogs (e.g. alert/confirm/prompt).

Categories

(Toolkit :: UI Widgets, defect)

Product:
Toolkit
Component:
UI Widgets
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.3a1
Tracking Flags:
Tracking Status
status1.9.2 --- beta2-fixed
status1.9.1 --- .8-fixed

People

(Reporter: Natch, Assigned: Natch)

References

Details

Attachments

(1 file, 1 obsolete file)

"common-dialog-loaded"
726 bytes, patch
enndeakin
: review+
beltzner
: approval1.9.2+
Details | Diff | Splinter Review
Attached patch patch (obsolete) — — Splinter Review 
This would be nice instead of hacking around with nsIComponentReistrar.
Attachment #409160 - Flags: review?(enndeakin)
Flags: wanted1.9.2?
The topic name would be better described as 'common-dialog-loaded'
Done.
Attachment #409160 - Attachment is obsolete: true
Attachment #409163 - Flags: review?(enndeakin)
Attachment #409160 - Flags: review?(enndeakin)
Attachment #409163 - Flags: review?(enndeakin) → review+
This is needed for the test in bug 498648.
Keywords: checkin-needed
Attachment #409163 - Flags: approval1.9.2?
http://hg.mozilla.org/mozilla-central/rev/73cf9d1f2883
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
Attachment #409163 - Flags: approval1.9.2? → approval1.9.2+
Comment on attachment 409163 [details] [diff] [review]
"common-dialog-loaded"

a192=beltzner
Flags: wanted1.9.2?
Keywords: checkin-needed
Whiteboard: [needs 192 landing]
The patch for this bug has landed on 1.9.1 as part of bug 498648, but that patch did not work because the observerService variable was undeclared in 1.9.1.  This patch fixes the issue:

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/6f4f1c26308a

This patch also fixes the perma-orange in bug 543071.
Blocks: 543071
status1.9.1: --- → .8-fixed
No longer blocks: 543071
Blocks: 543071
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: