Make it simpler to test modal dialogs (e.g. alert/confirm/prompt).

RESOLVED FIXED in mozilla1.9.3a1

Status

()

Toolkit
XUL Widgets
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Natch, Assigned: Natch)

Tracking

Trunk
mozilla1.9.3a1
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(status1.9.2 beta2-fixed, status1.9.1 .8-fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

726 bytes, patch
Neil Deakin (mostly unavailable until September)
: review+
beltzner
: approval1.9.2+
Details | Diff | Splinter Review
(Assignee)

Description

8 years ago
Created attachment 409160 [details] [diff] [review]
patch

This would be nice instead of hacking around with nsIComponentReistrar.
Attachment #409160 - Flags: review?(enndeakin)
Flags: wanted1.9.2?
The topic name would be better described as 'common-dialog-loaded'
(Assignee)

Comment 2

8 years ago
Created attachment 409163 [details] [diff] [review]
"common-dialog-loaded"

Done.
Attachment #409160 - Attachment is obsolete: true
Attachment #409163 - Flags: review?(enndeakin)
Attachment #409160 - Flags: review?(enndeakin)
Attachment #409163 - Flags: review?(enndeakin) → review+
(Assignee)

Comment 3

8 years ago
This is needed for the test in bug 498648.
Keywords: checkin-needed
(Assignee)

Updated

8 years ago
Attachment #409163 - Flags: approval1.9.2?
http://hg.mozilla.org/mozilla-central/rev/73cf9d1f2883
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
Attachment #409163 - Flags: approval1.9.2? → approval1.9.2+
Comment on attachment 409163 [details] [diff] [review]
"common-dialog-loaded"

a192=beltzner
(Assignee)

Updated

8 years ago
Flags: wanted1.9.2?
Keywords: checkin-needed
Whiteboard: [needs 192 landing]
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/ac2f6b49b03e
status1.9.2: --- → final-fixed
Keywords: checkin-needed
Whiteboard: [needs 192 landing]
The patch for this bug has landed on 1.9.1 as part of bug 498648, but that patch did not work because the observerService variable was undeclared in 1.9.1.  This patch fixes the issue:

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/6f4f1c26308a

This patch also fixes the perma-orange in bug 543071.
Blocks: 543071
status1.9.1: --- → .8-fixed
No longer blocks: 543071
Blocks: 543071
You need to log in before you can comment on or make changes to this bug.