525377 - tbpl should order mochitest chunks

Status: VERIFIED FIXED

(Tree Management Graveyard :: TBPL, enhancement)

Description

[Serge Gautherie (:sgautherie)]

It should display them as:
M1  M2  M3  M4  M5
Mo1 Mo2 Mo3 Mo4 Mo5
Md1 Md2 Md3 Md4 Md5

not randomly ordered.
(example: M1 M4 M3 M5 M2 Mo4 Mo5 Mo3 Mo2 Mo1 Md3 Md2 Md5 Md4 Md1)

Comment 1

[Marco Bonardo [:mak]]

yesterda there was a brief talk ongoing in developers about showing M[1 2 3 4 5] Mo[1 2 3 4 5] and so on...
but i can't find a bug about that.

Comment 2

[Markus Stange [:mstange]]

This is the bug about it :)

Comment 3

[Arpad Borsos [:Swatinem]]

Without knowing of this bug, I implemented this feature independently in my clone.
You can test it here: http://tbpl.swatinem.de/
Markus will pull from me shortly.

Comment 4

[Markus Stange [:mstange]]

http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/460a6ef67ccb
http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/d42394765f6c
http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/1a43512c8996
http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/a7a8e7a8de97

Oops, forgot the bug number in the checkin message.

Also, this doesn't really look good yet - please file bugs with suggestions!

Comment 5

[Serge Gautherie (:sgautherie)]

Something wrong on FF3.6 (and FF3.5), which doesn't use chunks:
I see (2009.11.12 17:56:30 -8) "M []" or "M [ ]";
there were (2009.11.12 09:39:08 -8) a few "M [*]" () too...

As for suggestions,
*maybe the space after the letter could be removed?
*maybe it could use "()" instead of "[]"?
*maybe the letter (and "brackets") could take the color of the worst case: purple/red/orange/green/gray?

Comment 6

[Serge Gautherie (:sgautherie)]

(In reply to comment #5)
> there were (2009.11.12 09:39:08 -8) a few "M [*]" () too...

This case happens when a comment is added: the number is missing.

Comment 7

[Serge Gautherie (:sgautherie)]

(In reply to comment #6)
> (In reply to comment #5)
> > there were (2009.11.12 09:39:08 -8) a few "M [*]" () too...
> 
> This case happens when a comment is added: the number is missing.

Sorry, no number on FF3.6: for both issues, chunk notation should just not be applied on these trees.

Comment 8

[Markus Stange [:mstange]]

Oh man. My testing is lacking in thoroughness.

Turn off Mochitest chunking on Firefox 3.6:
http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/49a8c492607d

Tweak the appearance:
http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/3312044bbf98

I didn't remove the space between the letter and the brackets, I only made it a little smaller.

Comment 9

[Marco Bonardo [:mak]]

i must say this grouping is really awesome and helps a lot.

Comment 10

[Serge Gautherie (:sgautherie)]

V.Fixed.

I filed bug 528450 on my 3rd suggestion.

Comment 11

[Serge Gautherie (:sgautherie)]

Ah, yet another case: '(1 2 3 4 5 1 2 3 4 5)'.
Should be '(1 1 2 2 3 3 4 4 5 5)'.