525467 - URL-bar remains orange-highlighted, even when it is not focused

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Brian Crowder]

I think the highlighting should go away as soon as typing focus leaves the URL-bar area.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

I see this after double tapping to zoom. Ben, any ideas?

Comment 2

[Benjamin Stover (:stechz)]

Attachment: Check target for mousedown

Since browser UI listens for window and urlbar mousedowns, check for target.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 409444 [details] [diff] [review]
Check target for mousedown

>         if (aEvent.detail == 2 &&
>             aEvent.button == 0 &&
>+            aEvent.target == this._edit &&
>             gPrefService.getBoolPref("browser.urlbar.doubleClickSelectsAll")) {
>           this._edit.editor.selectAll();
>           aEvent.preventDefault();

We add the mousedown listener to the editare, not just the textbox itself. The editarea is the white box around the textbox. We should test for it too.

You might be able to use one of the many event.xxxTarget properties to find the editarea element alone, or just add it to the check.

Also, at this point, I'd be happy if the if check was brkeon inot nested if statements. It's getting too big and hairy.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

fixed by bug 557619

Comment 6

[Martijn Wargers (dead)]

Verifixed fixed, using:
Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.3a5pre) Gecko/20100420 Namoroka/3.7a5pre Fennec/1.1a2pre