Closed
Bug 525479
Opened 15 years ago
Closed 15 years ago
[injection] Change to kIntegerType atoms is causing a performance testcase to fail validation
Categories
(Tamarin Graveyard :: Virtual Machine, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: brbaker, Assigned: stejohns)
References
Details
Attachments
(1 file)
|
1.91 KB,
patch
|
edwsmith
:
review+
|
Details | Diff | Splinter Review |
sunspider/crypto-sha1.as is failing self validation when running the interpreter on 32 bit vm shells. JIT and 64bit versions are still passing the self validation in the test.
./avmshell -Dinterp ~/hg/tamarin-redux/test/performance/sunspider/crypto-sha1.abc
error hex_sha1 expected 2524d264def74cce2498bf112bedf00e6c0b796d got d31da473c83eeb88947ecf6bc280fe28faf1ae31
Flags: in-testsuite+
Flags: flashplayer-triage+
Flags: flashplayer-qrb?
|
Assignee | |
Comment 1•15 years ago
|
||
Optimization in urshift was too aggressive. This corrects it, and reworks MAKE_INTEGER to do sanity checking in debug mode.
Assignee: nobody → stejohns
Attachment #409361 -
Flags: review?(edwsmith)
|
||
Updated•15 years ago
|
Attachment #409361 -
Flags: review?(edwsmith) → review+
|
|
Assignee | |
Comment 2•15 years ago
|
||
pushed as changeset: 2958:971ba2e54cf0
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
Reporter | |
Comment 3•15 years ago
|
||
testcase is passing, confirmed in build 2966
Status: RESOLVED → VERIFIED
Flags: flashplayer-qrb?
You need to log in
before you can comment on or make changes to this bug.
Description
•