Closed Bug 525588 Opened 11 years ago Closed 11 years ago

Some existing necko tests failing once base class catches handler exceptions

Categories

(Core :: Networking, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.3a1

People

(Reporter: jduell.mcbugs, Assigned: lusian)

References

Details

Attachments

(1 file, 1 obsolete file)

The patch for bug 521258 has exposed some errors in the existing necko unit tests.  Some tests which previously passed are now catching errors in one of OnStartRequest, OnDataAvailable, and/or OnStopRequest.  We should apply the patch for bug 521258 on a test box, figure out which tests are failing, and fix them before we can land the patch.

Jae-Seong, are you interested in working on this?  I'm too busy with electrolysis stuff to do it myself right now.
Sure, I will take a look.
httpserver.stop() throws NS_ERROR_NULL_POINTER if the callback is null.
Attachment #409511 - Attachment is obsolete: true
Attachment #409512 - Flags: review?(darin.moz)
Comment on attachment 409512 [details] [diff] [review]
httpserv.stop(do_test_finished)

Patch is good--thanks!

No need for sr on this. 

Jae-Seong: Darin no longer reviews patches, so he's not a good person to give reviews to.
Attachment #409512 - Flags: review?(darin.moz) → review+
Keywords: checkin-needed
Assignee: nobody → lusian
http://hg.mozilla.org/mozilla-central/rev/28e4094634a7
Status: NEW → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
You need to log in before you can comment on or make changes to this bug.