Closed
Bug 525588
Opened 15 years ago
Closed 15 years ago
Some existing necko tests failing once base class catches handler exceptions
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a1
People
(Reporter: jduell.mcbugs, Assigned: lusian)
References
Details
Attachments
(1 file, 1 obsolete file)
|
2.80 KB,
patch
|
jduell.mcbugs
:
review+
|
Details | Diff | Splinter Review |
The patch for bug 521258 has exposed some errors in the existing necko unit tests. Some tests which previously passed are now catching errors in one of OnStartRequest, OnDataAvailable, and/or OnStopRequest. We should apply the patch for bug 521258 on a test box, figure out which tests are failing, and fix them before we can land the patch. Jae-Seong, are you interested in working on this? I'm too busy with electrolysis stuff to do it myself right now.
|
Assignee | |
Comment 1•15 years ago
|
||
Sure, I will take a look.
|
|
Assignee | |
Comment 2•15 years ago
|
||
httpserver.stop() throws NS_ERROR_NULL_POINTER if the callback is null.
|
|
Assignee | |
Comment 3•15 years ago
|
||
Attachment #409511 -
Attachment is obsolete: true
Attachment #409512 -
Flags: review?(darin.moz)
|
Reporter | |
Comment 4•15 years ago
|
||
Comment on attachment 409512 [details] [diff] [review] httpserv.stop(do_test_finished) Patch is good--thanks! No need for sr on this. Jae-Seong: Darin no longer reviews patches, so he's not a good person to give reviews to.
Attachment #409512 -
Flags: review?(darin.moz) → review+
|
|
Reporter | |
Updated•15 years ago
|
Keywords: checkin-needed
|
||
Updated•15 years ago
|
Assignee: nobody → lusian
|
||
Comment 5•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/28e4094634a7
Status: NEW → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
You need to log in
before you can comment on or make changes to this bug.
Description
•