525708 - mIconURL shouldn't need to be accessed outside of tabbrowser.xml

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

Rather than having everybody access browser.mIconURL, this passes the URL to onLinkIconAvailable and also adds a getIcon method, which complements setIcon.

Comment 1

[Asaf Romano (gone)]

Comment on attachment 409570 [details] [diff] [review]
patch

s/var/let/ in new code.

r=mano.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Why does getIcon take a tab? Don't most tabbrowser accessors take <browser>s? It's also easier to get from tab->browser than vice-versa, IIRC.

Comment 3

[Dão Gottwald [:dao]]

Some take a tab, some take a browser. setIcon specifically takes a tab.

Comment 4

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/600620f684f5

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed based on check-in and testing with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a1pre) Gecko/20091220 Minefield/3.7a1pre ID:20091220030635.

Adding in-testsuite+ because we have a test here.

Comment 6

[Eric Shepherd [:sheppy]]

Documented browser.getIcon here:

https://developer.mozilla.org/en/XUL/Method/getIcon

And while I was at it, noticed that setIcon() wasn't documented, so wrote it up too:

https://developer.mozilla.org/en/XUL/Method/setIcon

Also added to Firefox 4 for developers.

Comment 7

[Dão Gottwald [:dao]]

We'll also need the extra argument for onLinkIconAvailable.