mIconURL shouldn't need to be accessed outside of tabbrowser.xml

VERIFIED FIXED in Firefox 3.7a1

Status

()

Firefox
Tabbed Browser
VERIFIED FIXED
9 years ago
8 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

({dev-doc-complete})

Trunk
Firefox 3.7a1
dev-doc-complete
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Created attachment 409570 [details] [diff] [review]
patch

Rather than having everybody access browser.mIconURL, this passes the URL to onLinkIconAvailable and also adds a getIcon method, which complements setIcon.
Attachment #409570 - Flags: review?(gavin.sharp)
Comment on attachment 409570 [details] [diff] [review]
patch

s/var/let/ in new code.

r=mano.
Attachment #409570 - Flags: review?(gavin.sharp) → review+
Why does getIcon take a tab? Don't most tabbrowser accessors take <browser>s? It's also easier to get from tab->browser than vice-versa, IIRC.
(Assignee)

Comment 3

9 years ago
Some take a tab, some take a browser. setIcon specifically takes a tab.
(Assignee)

Comment 4

9 years ago
http://hg.mozilla.org/mozilla-central/rev/600620f684f5
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a1
Verified fixed based on check-in and testing with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a1pre) Gecko/20091220 Minefield/3.7a1pre ID:20091220030635.

Adding in-testsuite+ because we have a test here.
Status: RESOLVED → VERIFIED
Flags: in-testsuite+
(Assignee)

Updated

8 years ago
Keywords: dev-doc-needed
Documented browser.getIcon here:

https://developer.mozilla.org/en/XUL/Method/getIcon

And while I was at it, noticed that setIcon() wasn't documented, so wrote it up too:

https://developer.mozilla.org/en/XUL/Method/setIcon

Also added to Firefox 4 for developers.
Keywords: dev-doc-needed → dev-doc-complete
(Assignee)

Comment 7

8 years ago
We'll also need the extra argument for onLinkIconAvailable.
You need to log in before you can comment on or make changes to this bug.