525724 - Use CSS transitions for the tab bar overflow animation

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, enhancement)

Description

[Dão Gottwald [:dao]]

Attachment: patch

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 409586 [details] [diff] [review]
patch

Neat!

Comment 2

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/50ebd8af726d

Comment 3

[AKIHIRO Misaki (a.k.a Kuden)]

This doesn't work well...

In this case (write userChrome.css):
.tabbrowser-arrowscrollbox > .scrollbutton-down:hover:active {
  background-color: #ff0000 !important;
}

:hover:active does animation.
This is not preferable behavior.

This doesn't work well either:
.tabbrowser-arrowscrollbox > .scrollbutton-down:not(:hover:active) {
  -moz-transition: 1s background-color ease-out;
}

Comment 4

[Dão Gottwald [:dao]]

You don't need to use background-color for the transition if this interferes with other states. See for instance gnomestripe, which uses -moz-box-shadow.

Comment 5

[AKIHIRO Misaki (a.k.a Kuden)]

(In reply to comment #4)
> You don't need to use background-color for the transition if this interferes
> with other states. See for instance gnomestripe, which uses -moz-box-shadow.

These work well. 

.tabbrowser-arrowscrollbox > .scrollbutton-down {
  -moz-transition: 1s background-color ease-out;
}

.tabbrowser-arrowscrollbox > .scrollbutton-down:hover,
.tabbrowser-arrowscrollbox > .scrollbutton-up:hover:active {
  -moz-transition: none;
}

.tabbrowser-arrowscrollbox > .scrollbutton-down:hover:active {
  background-color: #ff0000;
}

However, I don't understand whether a present implement is good or bad.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Dao, while checking this bug I miss some information. So is it just an improvement when you scroll the tab bar? Or is it about the arrows on both sides?

Comment 7

[Dão Gottwald [:dao]]

This is about the scroll arrow at the end of the tab strip, which me animate briefly when a tab has been opened offscreen.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

That's neat! Thanks for the info. Now that I can see it with one of the latest Minefield nightlies. Verified fixed on all platforms with builds like Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a1pre) Gecko/20091109 Minefield/3.7a1pre ID:20091109034249