525751 - Page shows white space when clicking on an in-game link and when updating page

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Paul Wright]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2b1) Gecko/20091029 Firefox/3.6b1 (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2b1) Gecko/20091029 Firefox/3.6b1 (.NET CLR 3.5.30729)

When clicking on an in-game link, link turns white and page turns white before updating.  Also, in-game timers flash while updating.
Firefox 3.5 did not show this behavior (3.5 through 3.5.4 are all OK).

Reproducible: Always

Steps to Reproduce:
1. Go to Mafia Wars game on Tagged
2. Clink on most any button within the game.
3. 
Actual Results:  
Clicked button and most of page turns white briefly before updating.

Expected Results:  
Page should not turn white in any area.

about:buildconfig

Source

Built from http://hg.mozilla.org/releases/mozilla-1.9.2/rev/3b49c063bb42
Build platform
target
i686-pc-mingw32

Build tools
Compiler 	Version 	Compiler flags
cl 	14.00.50727.762 	-TC -nologo -W3 -Gy -Fdgenerated.pdb -DNDEBUG -DTRIMMED -Zi -UDEBUG -DNDEBUG -GL -wd4624 -wd4952 -O1
cl 	14.00.50727.762 	-GR- -TP -nologo -Zc:wchar_t- -W3 -Gy -Fdgenerated.pdb -DNDEBUG -DTRIMMED -Zi -UDEBUG -DNDEBUG -GL -wd4624 -wd4952 -O1

Configure arguments
--enable-application=browser --enable-update-channel=beta --enable-update-packaging --enable-jemalloc --enable-official-branding

Comment 1

[Paul Wright]

Is anybody looking into this?

Comment 2

[Paul Wright]

Further information:
If playing the Mafia Wars game while on the Tagged website (www.tagged.com/mafiawars.html) the condition is true.

If opening the game in a new tab and playing it outside of the Tagged website (http://mwtg.zynga.com/mwtg/remote/html_server.php?xw_controller=index&xw_action=view) the condition does not occur.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I think I see the bug on Mac. Some of the areas I click on while they're in the IFRAME turn white briefly.

I kinda suspect this is related to the work Timothy did on document backgrounds.

Comment 4

[Timothy Nikkel (:tnikkel)]

In nsSubDocumentFrame::BuildDisplayList when adding the canvas background color if we don't have a root frame for the subdocument (during loading, etc) we pass the subdocument frame instead. But bug 502424 caused non-canvas frames (in this case iframe) to be ignored and not draw a canvas background color. So we either need an override parameter to PresShell::AddCanvasBackgroundColorItem to force a background or to check the type of aFrame and specifically allow subdocument frames.

Comment 5

[Timothy Nikkel (:tnikkel)]

Attachment: patch

Allow subdocument frames in PresShell::AddCanvasBackgroundColorItem.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Can't the subtree root be an nsSubdocumentFrame, e.g. if we're dragging an IFRAME element, where we wouldn't want to add an item for the background color of the canvas containing the IFRAME? I think an explicit parameter would be safer here.

Comment 7

[Timothy Nikkel (:tnikkel)]

The dragging code doesn't call AddCanvasBackgroundColorItem, but point taken, new patch coming up.

Comment 8

[Timothy Nikkel (:tnikkel)]

Attachment: patch v2

Add a parameter to AddCanvasBackgroundColor item to force drawing of background and use it for subdocument frames.

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Revving the nsIPresShell IID on 1.9.2 at this point is not a good idea. If we want this on 1.9.2 (I think we do) we need to add to nsIPresShell_MOZILLA_1_9_2

Comment 10

[Timothy Nikkel (:tnikkel)]

Thanks for the heads up, will post a 1.9.2 patch soon.

Comment 11

[Timothy Nikkel (:tnikkel)]

Attachment: patch v2 for 1.9.2

Comment 12

[Timothy Nikkel (:tnikkel)]

http://hg.mozilla.org/mozilla-central/rev/cbfc6b1cf11c

Comment 13

[Timothy Nikkel (:tnikkel)]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/140ae2aa7f1a

Comment 14

[Paul Wright]

(In reply to comment #13)
> http://hg.mozilla.org/releases/mozilla-1.9.2/rev/140ae2aa7f1a

No more white space, but now the button clicked and certain areas of the frame turn black in Firefox 3.6 b5.  Please review for this condition.  See attachments of before button is clicked and after clicking (but before page updates).

Comment 15

[Paul Wright]

Attachment: Before clicking

Comment 16

[Paul Wright]

Attachment: clicking attack

Comment 17

[Paul Wright]

Attachment: clicked home

Comment 18

[Timothy Nikkel (:tnikkel)]

I filed bug 536926 for the issue in comment 15 because it seems to be a separate issue.