525888 - [Midas] execCommand(indent) should place the ul inside li, not ul inside ul

Status: RESOLVED DUPLICATE of bug 54479

(Core :: DOM: Editor, defect, P2)

Description

[Joris van der Wel [:JoWie]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2b1) Gecko/20091029 Firefox/3.6b1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2b1) Gecko/20091029 Firefox/3.6b1

When using execCommand(indent) on a list, an ul/ol is placed directly under the parent ul/ol. This is invalid HTML 4 strict: http://www.w3.org/TR/html4/struct/lists.html#edef-UL

Related to bug 485466

Reproducible: Always

Steps to Reproduce:
1. Goto http://www.mozilla.org/editor/midasdemo/
2. Create a list with 2 items
3. Indent the second item
4. View the source
Actual Results:  
<ul>
  <li>First</li>
  <ul>
    <li>Second</li>
  </ul>
</ul>

Expected Results:  
<ul>
  <li>First
    <ul>
      <li>Second</li>
    </ul>
  </li>
</ul>

Comment 1

[Jeff Muizelaar [:jrmuizel]]

All major browsers have this behaviour.

Comment 2

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

And the editing spec requires it.  The markup is invalid, though: <https://www.w3.org/Bugs/Public/show_bug.cgi?id=12609>

Comment 3

[Mats Palmgren (inactive)]

Attachment: Testcase

This came up in bug 1548753. The invalid markup has the effect that we get unexpected list numbers because we're now using the CSS built-in 'list-item' counter for HTML lists (which means an <ol> affects any sibling <li>s after it).

Comment 4

[Mats Palmgren (inactive)]

The HTML spec is quite clear that only <li>s (and <script>) are valid inside <ol>:
https://html.spec.whatwg.org/multipage/grouping-content.html#the-ol-element
(ditto for <ul> and <menu>)
So we should fix this...

Comment 5

[Mats Palmgren (inactive)]

Attachment: hack

Wrapping the child <ol> we're currently inserting in a <li style="display:block"> might be a solution?
I guess we'd need to account for this in the "outdent" command though?

Feel free to take it from here...

(BTW, there's an amazing amount of copy-pasted code between IndentAroundSelectionWithHTML and IndentAroundSelectionWithCSS which we probably should share...)

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Currently, we cannot fix this bug at least for now since the other browsers also behave so. Therefore, fixing this bug may cause web-compat issue. If we need to fix this, you need to ask Google and Apple about this issue first.

Comment 7

[Mats Palmgren (inactive)]

Fair enough, do we have any contacts there that are working on execCommand/editor code?

Given the state of the execCommand spec is effectively "abandoned" we should probably try to remove these commands from the web platform. Again, this requires vendor coordination of course.