525975 - White spaces at EOL in nsViewManager.cpp

Status: RESOLVED INVALID

(Core :: Web Painting, defect)

Description

[Mike Kristoffersen (:MikeK)]

Attachment: Patch with the whitespaces at EOL removed

Not sure the component is correct on this one - if wrong please advice of correct one...

/view/src/nsViewManager.cpp contains white spaces at EOL.

These white spaces are preventing me getting a larger patch reviewed.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

These whitespace patches don't need a bug/review for every file - a bug per component, or even a single bug for all of them would have done just fine.

Comment 2

[Mike Kristoffersen (:MikeK)]

(In reply to comment #1)
> These whitespace patches don't need a bug/review for every file - a bug per
> component, or even a single bug for all of them would have done just fine.

np, will collect them pr. module owner next time.  Assume one patch per file thou?  (since they are in essence independent?)

Comment 3

[:Gavin Sharp [email: [e-mail]]]

No, a single patch per module is fine too. There aren't really any benefits to patch-per-file, and there are obviously costs :)

Comment 4

[Mike Kristoffersen (:MikeK)]

(In reply to comment #3)
> No, a single patch per module is fine too. There aren't really any benefits to
> patch-per-file, and there are obviously costs :)

Sorry I seem to have missed your comment until now, I would be happy to make a module wide (or even "global" patch) to fix this, but it seems I'm meeting great resistance against the whole idea of dealing with this issue by simply removing the whitespaces at EOL - so I'm closing this bug while I re-order my troops and prepare to attack the issue from a different angel.