52599 - <xul:srollbar>s should generate onscroll events

Status: RESOLVED WORKSFORME

(Core :: XUL, defect, P3)

Description

[Robert Ginda]

<xul:scrollbar> tags are pretty useless to javascript w/o onscroll events.  This
patch adds them.  It worksforme on linux.  onscroll even gets generated for
scrolls of HTML documents, so it's a css standards fix as well!   I'm looking
for an r=, and armed with that, will attemt to check in before the rtm
branch/closure.

Comment 1

[Robert Ginda]

Attachment: layout.diff; changes to mozilla/layout

Comment 2

[Robert Ginda]

Attachment: rdf.diff; changes to mozilla/rdf

Comment 3

[David Hyatt]

Looks good to me. Will let eric comment on his area.

Comment 4

[Peter Trudelle]

reassigning to rginda, who evaughan says has a fix.

Comment 5

[Eric Vaughan]

Looks good. r=evaughan

Comment 6

[Alex Stewart]

So what happened?  Last comment was more than a year ago, and was an r=.

Comment 7

[Robert Ginda]

Two problems kept me from actually checking the patch in.  Firstly, I only
tested it on linux, and second, it left us open to a infinite recursion.  If the
onscroll handler causes another scroll, it'll be called again, which will cause
another scroll, etc.
In addition to those problems, I ended up working around this problem, and so it
was easy for me to lame out :(

Comment 8

[Fabian Guisset]

I'm working on this as part of bug 62536

Comment 9

[TimMaroney]

Also see bug 35011.

Comment 10

[Boris Zbarsky [:bzbarsky]]

Is this still relevant now that bug 35011 has landed?

Comment 11

[Neil Deakin]

scroll events do fire in xul