526011 - NJ: Remove Fragment::root and Fragment::vmprivate

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

Tamarin doesn't use these and TraceMonkey doesn't need to use them either, after bug 524620.

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: patch

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 409792 [details] [diff] [review]
patch

@edwsmith: Making TR compatible with this change is just removing one line of code in CodegenLIR.cpp, I think.

Comment 3

[Edwin Smith]

Comment on attachment 409792 [details] [diff] [review]
patch

yup

Comment 4

[David Anderson [:dvander] - inactive, e-mail if emergency]

http://hg.mozilla.org/projects/nanojit-central/rev/ccae3c736aed

Comment 5

[Graydon Hoare :graydon]

In the future it'd be good to land pairs like this in dependency order if possible. That is, holding off on this one until tm was ready for it (post bug 524620). As it is, we now can't do an n-c -> tm propagation until bug 524620 lands, because it'll bring this one along, and break the tm build.

Not a huge deal, I figure it'll un-clog later today. Just pointing it out.

Comment 6

[David Anderson [:dvander] - inactive, e-mail if emergency]

Graydon: Yeah I realized that after I pushed :( feel free to back out if it becomes a problem.

Comment 7

[Graydon Hoare :graydon]

backed out: http://hg.mozilla.org/projects/nanojit-central/rev/ba29ca88bc1a

Comment 8

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/b64f119567bf

Comment 9

[David Anderson [:dvander] - inactive, e-mail if emergency]

m-c backout: http://hg.mozilla.org/mozilla-central/rev/f0d5ea88d07f

Comment 10

[David Anderson [:dvander] - inactive, e-mail if emergency]

http://hg.mozilla.org/projects/nanojit-central/rev/728855b3a0b3
http://hg.mozilla.org/tracemonkey/rev/06e6c525b8b7