Closed Bug 526011 Opened 12 years ago Closed 12 years ago

NJ: Remove Fragment::root and Fragment::vmprivate

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: dvander, Assigned: dvander)

Details

(Whiteboard: fixed-in-nanojit fixed-in-tracemonkey)

Attachments

(1 file)

Tamarin doesn't use these and TraceMonkey doesn't need to use them either, after bug 524620.
Attached patch patchSplinter Review
Assignee: general → dvander
Status: NEW → ASSIGNED
Attachment #409792 - Flags: review?(gal)
Comment on attachment 409792 [details] [diff] [review]
patch

@edwsmith: Making TR compatible with this change is just removing one line of code in CodegenLIR.cpp, I think.
Attachment #409792 - Flags: review?(edwsmith)
Attachment #409792 - Flags: review?(gal) → review+
Attachment #409792 - Flags: review?(edwsmith) → review+
Comment on attachment 409792 [details] [diff] [review]
patch

yup
In the future it'd be good to land pairs like this in dependency order if possible. That is, holding off on this one until tm was ready for it (post bug 524620). As it is, we now can't do an n-c -> tm propagation until bug 524620 lands, because it'll bring this one along, and break the tm build.

Not a huge deal, I figure it'll un-clog later today. Just pointing it out.
Graydon: Yeah I realized that after I pushed :( feel free to back out if it becomes a problem.
http://hg.mozilla.org/mozilla-central/rev/b64f119567bf
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
m-c backout: http://hg.mozilla.org/mozilla-central/rev/f0d5ea88d07f
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → RESOLVED
Closed: 12 years ago12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.