526147 - Assert l10nbuilds.ini file exists when setting up the l10n scheduler

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Chris Cooper [:coop] (he/him)]

This is a follow-up to bug 524798.

To avoid losing l10n repacks for a month again, I submit that we should be asserting that the l10nbuilds.ini file actually exists at buildbot master startup and failing if it does not. 

Axel: is there a reason why we wouldn't be able to do a simple assert on the inipath in startService() in the l10n scheduler?

Comment 1

[Axel Hecht [:Pike]]

I'd even put it into __init__ as that should produce a fatal error on start or reconfig. I guess that startService would error async and late, and possibly just make the master wonky.

Comment 2

[Chris Cooper [:coop] (he/him)]

Attachment: Assert that l10nbuilds.ini exists

Causes the master to fail out during checkconfig when l10nbuilds.ini (or symlink) is missing.

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 411348 [details] [diff] [review]
Assert that l10nbuilds.ini exists

changing review request, community doesn't do reviews...

Comment 4

[Chris Cooper [:coop] (he/him)]

(In reply to comment #3)
> (From update of attachment 411348 [details] [diff] [review])
> changing review request, community doesn't do reviews...

What, no crowd-sourcing? ;) Bugzilla auto-complete fail.

Comment 5

[Chris Cooper [:coop] (he/him)]

Comment on attachment 411348 [details] [diff] [review]
Assert that l10nbuilds.ini exists

Axel: did you want something more elaborate than this simple assert?

Comment 6

[Axel Hecht [:Pike]]

Comment on attachment 411348 [details] [diff] [review]
Assert that l10nbuilds.ini exists

nah, that should be good for now.

Comment 7

[Chris Cooper [:coop] (he/him)]

Comment on attachment 411348 [details] [diff] [review]
Assert that l10nbuilds.ini exists

http://hg.mozilla.org/build/buildbotcustom/rev/d483ab29d8f9

Comment 8

[Chris Cooper [:coop] (he/him)]

production-master* have been reconfig-ed with this change.