526148 - Port Bug 525712 (Remove dead throbber-specific code from customizeToolbar.js, handle it in themes)

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Philip Chee]

+++ This bug was initially created as a clone of Bug #525712 +++

Comment 1

[Ian Neal]

Whilst you are at it is it worth changing all the
<toolbaritem id="throbber-box"...>
  <button id="navigator-throbber"...>
</toolbaritem>
into
<toolbaritem id="navigator-throbber".../>
I've also noticed that /suite/mailnews/addrbook/addressbox.xul has a navigator-throbber that observes the element broadcaster_throbber that does not exist (broadcaster-throbber does but I cannot see anything that actually changes it).
/suite/mailnews/compose/messengercompose.xul has a navigator-throbber that observes the element broadcaster_throbber that does not exist (nor does broadcaster-throbber in this case either).

Comment 2

[Philip Chee]

Attachment: Patch v1.0 SeaMonkey

Fix SeaMonkey throbber CSS following Firefox and Thunderbird.

Comment 3

[Philip Chee]

> Whilst you are at it is it worth changing all the
Separate bug for all those issues please.

Comment 4

[[e-mail]]

Comment on attachment 414962 [details] [diff] [review]
Patch v1.0 SeaMonkey

Sorry, this doesn't work with small icons.

Comment 5

[Philip Chee]

> Sorry, this doesn't work with small icons.
I didn't change anything that touched small icons. What do you mean "doesn't work with small icons" exactly?

Comment 6

[[e-mail]]

* Select "Use small icons"
* Customise toolbar

Would it help to change the existing "busy" rules to use toolbar > ?

Comment 7

[Philip Chee]

> * Select "Use small icons"
> * Customise toolbar
I don't see any change in the existing behaviour.

> Would it help to change the existing "busy" rules to use toolbar > ?
Good point. I'll test a new patch RSN.

Comment 8

[Philip Chee]

Attachment: Patch v1.1 LittleBig

> Sorry, this doesn't work with small icons.
Fixed small icons issue.

Comment 9

[[e-mail]]

Attachment: Perverse approach

Because customising toolbars removes the command attribute ;-)

Comment 10

[[e-mail]]

Comment on attachment 415151 [details] [diff] [review]
Patch v1.1 LittleBig

> window[chromehidden~="toolbar"] #navigator-throbber,
Can anyone remember what this does? I'm wondering whether it needs to work with toolbar customisation or whether we should just drop it completely.

Comment 11

[Philip Chee]

>> window[chromehidden~="toolbar"] #navigator-throbber,
> Can anyone remember what this does? I'm wondering whether it needs to work with
> toolbar customisation or whether we should just drop it completely.
I think it has something to do with full screen mode.

Comment 12

[[e-mail]]

Comment on attachment 415151 [details] [diff] [review]
Patch v1.1 LittleBig

... which of course isn't customisable.

Nit: for other rulesets I think we put the more complex rules first. This was probably to avoid changing the existing lines ;-)

Comment 13

[Philip Chee]

Comment on attachment 415151 [details] [diff] [review]
Patch v1.1 LittleBig

> Nit: for other rulesets I think we put the more complex rules first. This was
> probably to avoid changing the existing lines ;-)

Then eventually they get resorted in css clean-up drives. Or rather I file css clean up bugs and then forget to do them.

Comment 14

[Philip Chee]

Attachment: Patch v1.2 Complex first [Checkin: Comment 16]

> Nit: for other rulesets I think we put the more complex rules first. This was
> probably to avoid changing the existing lines ;-)

Fixed.

Comment 15

[[e-mail]]

Comment on attachment 416879 [details] [diff] [review]
Patch v1.2 Complex first
[Checkin: Comment 16]

Checked ;-)

Comment 16

[Serge Gautherie (:sgautherie)]

Comment on attachment 416879 [details] [diff] [review]
Patch v1.2 Complex first
[Checkin: Comment 16]


http://hg.mozilla.org/comm-central/rev/eef17e975072