52615 - Proxy: FTP does not show proxy auth (when proxy sends 407)

Status: VERIFIED FIXED

(Core Graveyard :: Networking: FTP, defect, P3)

Description

[Matt Behrens]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; WinNT4.0; en-US; m18) Gecko/20000913
BuildID:    2000091317

FTP-thru-proxy now works, unless you are using a proxy server and said proxy
server requires you to authenticate yourself -- and you have not yet
authenticated for this session.

Reproducible: Always
Steps to Reproduce:
1. start Moz
2. try to go to an FTP url (spinner spins, nothing)
3. go to an HTTP url, enter proxy username/password
4. try to go to an FTP url (success!)

When I sniffed traffic on my machine, I found that if I had not yet entered
proxy credentials, Moz was indeed trying to contact the proxy server but didn't
know what to do with the 407, so it gave up.

[Note: As far as severity goes, I had some trouble deciding.  Obviously there is
a workaround, but that workaround would not be considered acceptable for
deployment of Moz in organizations using proxies that require user
authentication.  I hope I made a fair decision.]

Comment 1

[Gervase Markham [:gerv]]

[e-mail] - are you still seeing this problem on recent builds 
of Mozilla? If so, we'll confirm this bug.

Gerv

Comment 2

[Matt Behrens]

Yes, it's still an issue with 2000102220 (Win32).

Comment 3

[Gagan]

ftp bugs to component:ftp

Comment 4

[Jimmy Uen]

This problem is also happening on the HPUX build, and with the latest Linux
build (2001011008) too.

Steps to reproduce:
1) start browser
2) setup proxy connections in preference to york.mcom.com:3128
3) go to URL ftp://username@hostname (e.g. ftp://[e-mail])

Result: nothing happens
Expected: a dialog box to enter the password

Comment 5

[Rob Jaworski]

I'm also seeing this on the Mac.  I'd like to change Platform and OS to All, but
bugzilla ain't letting me.

Comment 6

[Tom Mraz]

Please set platform, OS ->all Seeing it on Linux too.

Comment 7

[Matt Behrens]

Sorry, wasn't paying attention for a bit :-)

Comment 8

[Doug Turner (:dougt)]

Fixes checked in.  QA please verify.

Comment 9

[Jimmy Uen]

Unable to verify with Linux Build ID 2001051508.

Tested on proxy server : frame.packetgram.com:443

No dialog window prompt for authentication.

Comment 10

[Doug Turner (:dougt)]

does an auth dialog come up when going to a http site?  If not, than we need to
configure frame.packetgram.com:443 to do auth.

Ben, any thoughts about adding a port that is always for auth testing?  

Comment 11

[benc]

qa to me.

proxy.packetgram.com:443 is already doing ftp proxy, and it uses auth by default.

Since most people have been using it for http as well, it you need to configure
JUST ftp and not http proxy to get a clean look at the problem. (I've been
trying to file a bug on a similar problem, and if you proxy auth for http,
mozilla seeems to use it for ftp on the same proxy server.)

Comment 12

[Jimmy Uen]

Tested on proxy server york:3128 which doesn't auth at default. When connecting
to other http or ftp site that requires auth still doesn't prompt auth dialog
display.

Comment 13

[benc]

SERVER UPDATE:
proxy auth was not on for ftp URLs, I have fixed that. You can now attempt to
get an ftp URL via proxy.packetgram.com:443.

Make sure http proxy is OFF so you don't end up sharing the auth credentials.

Comm 4 - will show auth dialog
mozilla - will not show auth dialog

The reason this happens is the proxy server is returning a 407, but the
ftp+proxy module does not throw up a proxy auth dialog.

Here's my log file, the "407" is the HTTP response

208.12.40.178 - - [15/May/2001:17:58:58 -0700] "GET ftp://frame.packetgram.com/
HTTP/1.1" 407 271 - - - - 323 209 - - - - FIN - -

With communicator, if you type in the correct username:password, the log file
shows a "200" from the successful connection (Netscape Proxy globs the previous
407's into this record if session was eventual authed successfully).

208.12.40.178 - test [15/May/2001:18:05:44 -0700] "GET
ftp://frame.packetgram.com/ HTTP/1.0" 200 117 200 117 - - 351 115 - 115 0 DIRECT
FIN FIN DO-NOT-CACHE

Jimmy:
This is a separate (but probably related problem, where HTTP 401's from the
proxy are not handled. See bug: 81110

DougT:
Based on this new info, do you want me to check a certain build for a fix, or is
this a new problem?

Comment 14

[Doug Turner (:dougt)]

sounds like a new problem.

Comment 15

[benc]

VERIFIED:
+testcase - I hacked the proxy functional test to suggest each protocol needs
the auth handlers teseted individually. Right now it is a template of
suggestions + a list of protocols.

Mozilla 0.9.5, allplats