526233 - l10n-merge for fennec builds isn't working.

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P1)

Description

[Axel Hecht [:Pike]]

l10n-merge for both the single and the multi-locale builds on fennec isn't working.

Compare-locales is called with

compare-locales', '-m', 'merged', 'l10n.ini', ..

and that puts the merged dir into the source.

The actual repack step expects the merge dir to be in the build dir, though.

It should be in the build dir, so either we need to call compare-locales in the build dir or redirect just the output of merge to that.

Comment 1

[Armen [:armenzg]]

Attachment: [buildbotcustom] create the merged directory where make chrome-ab-CD expects it

Comment 2

[Axel Hecht [:Pike]]

Comment on attachment 410021 [details] [diff] [review]
[buildbotcustom] create the merged directory where make chrome-ab-CD expects it

looking at http://hg.mozilla.org/build/buildbotcustom/file/38f5f50df47a/process/factory.py#l4132, this is not gonna work.

Comment 3

[Armen [:armenzg]]

Attachment: [buildbotcustom] create the merged directory where make chrome-ab-CD expects it

Worked on staging

Comment 4

[Armen [:armenzg]]

From the logs:
/scratchbox/users/cltbld/home/cltbld/build/maemo-1.9.2-nightly/mozilla-1.9.2/objdir/merged
LOCALE_MERGEDIR=build/maemo-1.9.2-nightly/mozilla-1.9.2/objdir/merged

Comment 5

[Armen [:armenzg]]

Comment on attachment 410045 [details] [diff] [review]
[buildbotcustom] create the merged directory where make chrome-ab-CD expects it

This does not yet work. I tried the builds on the device and "de" does not load.

Axel believes that trick is on using an absolute path.

Comment 6

[Armen [:armenzg]]

Added the absolute path did the trick. I will make sure that tomorrow morning we do a full clean run to be sure and create new nightly builds on production before noon.

Comment 7

[Armen [:armenzg]]

Attachment: [buildbotcustom] create the merged directory where make chrome-ab-CD expects it (v2)

This is what is running on staging. I am just waiting for the build to finish to request for reviews.

Comment 8

[Armen [:armenzg]]

Comment on attachment 410239 [details] [diff] [review]
 [buildbotcustom] create the merged directory where make chrome-ab-CD expects it (v2)

This worked on staging and the builds allowed to switch to "de" and "da" (the only l10n-merged locales) without crashing.

http://staging-stage.build.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mobile-1.9.2/xulrunner_1.9.2b2pre-20091104065826_armel.deb
http://staging-stage.build.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mobile-1.9.2/fennec_1.0b5_armel.deb

Comment 9

[Axel Hecht [:Pike]]

Comment on attachment 410239 [details] [diff] [review]
 [buildbotcustom] create the merged directory where make chrome-ab-CD expects it (v2)

r=me, with a nit that the /home/cltbld path could use comment if it needs to stay in sync with other configs. Or be a shared variable. Good follow up bug, perhaps?

Comment 10

[Chris Cooper [:coop] (he/him)]

Comment on attachment 410239 [details] [diff] [review]
 [buildbotcustom] create the merged directory where make chrome-ab-CD expects it (v2)

I'm with Axel on the /home/cltbld thing. Perhaps renaming those variables to indicate they point to scratchbox is enough?

Comment 11

[Armen [:armenzg]]

Comment on attachment 410239 [details] [diff] [review]
 [buildbotcustom] create the merged directory where make chrome-ab-CD expects it (v2)

http://hg.mozilla.org/build/buildbotcustom/rev/015d0fabaa4e

Added comments wrt the variable.

Comment 12

[Armen [:armenzg]]

New multi-locale has been triggered on pm2.
http://production-master02.build.mozilla.org:8010/builders/Maemo%20mozilla-1.9.2%20nightly
That build should not crash on switching to "de" or "da".

Comment 13

[Armen [:armenzg]]

Builds are l10n-merged. I tested "Dansk", "Deutsch" and "Nederlands" and worked fine.

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mobile-1.9.2/xulrunner_1.9.2b2pre-20091104100214_armel.deb
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mobile-1.9.2/fennec_1.0b5_armel.deb


Other things I noted was that:
* Dansk's starting page was in English.
* The application opened is "Firefox" but if you minimize you can see Fennec's icon on the left where all the Nokia's apps show up.