Closed
Bug 526271
Opened 16 years ago
Closed 16 years ago
Uninitialized value in can_enter_product() due to a missing argument
Categories
(Bugzilla :: Query/Bug List, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.6
People
(Reporter: LpSolit, Assigned: LpSolit)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
1.16 KB,
patch
|
gregaryh
:
review+
|
Details | Diff | Splinter Review |
buglist.cgi: Use of uninitialized value $warn in numeric eq (==) at Bugzilla/User.pm line 719
Bug 524234 defined one_product in some cases only, but call can_enter_product() unconditionally, throwing the error above.
We should fix two things: 1) buglist.cgi at line 1104 to only call can_enter_product() when one_product is defined, and 2) User::can_enter_product() to revert the changes included in bug 322848 (i.e. check for |if $warn| instead of |if $warn == THROW_ERROR|) or to set $warn ||= 0.
|
Assignee | |
Comment 1•16 years ago
|
||
Assignee: query-and-buglist → LpSolit
Status: NEW → ASSIGNED
Attachment #409972 -
Flags: review?(ghendricks)
|
|
||
Updated•16 years ago
|
Attachment #409972 -
Flags: review?(ghendricks) → review+
|
|
Assignee | |
Updated•16 years ago
|
Flags: approval+
|
|
Assignee | |
Comment 2•16 years ago
|
||
Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v <-- buglist.cgi
new revision: 1.407; previous revision: 1.406
done
Checking in Bugzilla/User.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/User.pm,v <-- User.pm
new revision: 1.195; previous revision: 1.194
done
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•