526276 - stop stuffing NSEvent objects into gecko event nativeMsg fields

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Josh Aas]

Attachment: fix v1.0

We should stop stuffing NSEvent objects into gecko event nativeMsg fields. Depending on the plugin event model that is expected to be a Carbon event or an NPCocoaEvent, but never an NSEvent.

Comment 1

[Josh Aas]

This is dangerous, blocking 1.9.2+.

Comment 2

[Steven Michaud [:smichaud] (Retired)]

Comment on attachment 409975 [details] [diff] [review]
fix v1.0

I can't see any problems with this change (though I haven't done any
testing).  There are lots of other cases in nsChildView.mm where
nsGUIEvent.nativeMsg gets set to NULL, and these don't seem to cause
trouble.

And yes, the current code definitely needs to be changed.

Comment 3

[Steven Michaud [:smichaud] (Retired)]

> There are lots of other cases in nsChildView.mm where
> nsGUIEvent.nativeMsg gets set to NULL, and these don't seem to cause
> trouble.

The patch doesn't explicitly NULL outGeckoEvent->nativeMsg.  But it's
always initialized to NULL.

Comment 4

[Josh Aas]

pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/1825c544f1ad

Comment 5

[Josh Aas]

pushed to mozilla-1.9.2

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/01e23c080f94