Closed Bug 526276 Opened 13 years ago Closed 13 years ago

stop stuffing NSEvent objects into gecko event nativeMsg fields

Categories

(Core Graveyard :: Plug-ins, defect)

All
macOS
defect
Not set
major

Tracking

(status1.9.2 beta2-fixed)

RESOLVED FIXED
Tracking Status
status1.9.2 --- beta2-fixed

People

(Reporter: jaas, Assigned: jaas)

References

Details

Attachments

(1 file)

Attached patch fix v1.0Splinter Review
We should stop stuffing NSEvent objects into gecko event nativeMsg fields. Depending on the plugin event model that is expected to be a Carbon event or an NPCocoaEvent, but never an NSEvent.
Attachment #409975 - Flags: review?(smichaud)
Blocks: 435041, 519100
Severity: normal → major
This is dangerous, blocking 1.9.2+.
Flags: blocking1.9.2+
Comment on attachment 409975 [details] [diff] [review]
fix v1.0

I can't see any problems with this change (though I haven't done any
testing).  There are lots of other cases in nsChildView.mm where
nsGUIEvent.nativeMsg gets set to NULL, and these don't seem to cause
trouble.

And yes, the current code definitely needs to be changed.
Attachment #409975 - Flags: review?(smichaud) → review+
> There are lots of other cases in nsChildView.mm where
> nsGUIEvent.nativeMsg gets set to NULL, and these don't seem to cause
> trouble.

The patch doesn't explicitly NULL outGeckoEvent->nativeMsg.  But it's
always initialized to NULL.
pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/1825c544f1ad
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.