Closed Bug 526276 Opened 13 years ago Closed 13 years ago
stop stuffing NSEvent objects into gecko event native
We should stop stuffing NSEvent objects into gecko event nativeMsg fields. Depending on the plugin event model that is expected to be a Carbon event or an NPCocoaEvent, but never an NSEvent.
Attachment #409975 - Flags: review?(smichaud)
This is dangerous, blocking 1.9.2+.
Comment on attachment 409975 [details] [diff] [review] fix v1.0 I can't see any problems with this change (though I haven't done any testing). There are lots of other cases in nsChildView.mm where nsGUIEvent.nativeMsg gets set to NULL, and these don't seem to cause trouble. And yes, the current code definitely needs to be changed.
Attachment #409975 - Flags: review?(smichaud) → review+
> There are lots of other cases in nsChildView.mm where > nsGUIEvent.nativeMsg gets set to NULL, and these don't seem to cause > trouble. The patch doesn't explicitly NULL outGeckoEvent->nativeMsg. But it's always initialized to NULL.
pushed to mozilla-central http://hg.mozilla.org/mozilla-central/rev/1825c544f1ad
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
pushed to mozilla-1.9.2 http://hg.mozilla.org/releases/mozilla-1.9.2/rev/01e23c080f94
You need to log in before you can comment on or make changes to this bug.