526302 - Wrong OS_TEST value when cross compiling on Linux with mingw.

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Jacek Caban]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.3) Gecko/20091028 Gentoo Firefox/3.5.3
Build Identifier: 

OS_TEST is overwritten when OS_ARCH is WINNT:

case "$OS_ARCH" in
WINNT)
    OS_TEST=`uname -p`
    ;;

It should be unchanged when cross compiling.

Reproducible: Always

Comment 1

[Jacek Caban]

Attachment: fix

Comment 2

[cls]

Comment on attachment 409999 [details] [diff] [review]
fix

The fix looks okay but incomplete. `uname -p` returns "unknown" for both cygwin & msys uname.  And there are bunch of other `uname` calls in that section that should not occur when cross-compiling.

rs=cls

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 409999 [details] [diff] [review]
fix

Yeah, because config.guess returns "i686-pc-mingw32" when building in MSYS, so we never hit that block, we hit this:
http://mxr.mozilla.org/mozilla-central/source/configure.in#1223

Comment 4

[Jacek Caban]

Thanks for reviews.

Comment 5

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/mozilla-central/rev/479d37add351