Closed
Bug 526389
Opened 15 years ago
Closed 15 years ago
remove duplicated prototypes from jemalloc.h
Categories
(Core :: Memory Allocator, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a3
People
(Reporter: t.matsuu, Assigned: t.matsuu)
Details
Attachments
(1 file)
|
1023 bytes,
patch
|
jasone
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; ja; rv:1.9.3a1pre) Gecko/20091104 Fedora/3.7a1pre-0.a1pre.2009110411.hg_8ff817d76d2a.fc11 Minefield/3.7a1pre
Build Identifier:
This bug is for the discussion of bug 422960 comment #7 and below.
malloc, valloc, calloc, realloc, free, posix_memalign, and memalign are already defined in system header (stdlib.h etc.) on some OSes. In glibc, some additional definition is added to these functions for exception handling (See bug 422960 comment #17).
So we should define prototypes above only for OSes which they are not defined.
I know
MOZ_MEMORY_DARWIN platform have malloc, vallod, calloc, realloc, free, and posix_memalign
MOZ_MEMORY_LINUX platform have malloc, valloc, calloc, realloc, free, posix_memalign, and memalign
but I don't know MOZ_MEMORY_BSD, MOZ_MEMORY_SOLARIS, MOZ_MEMORY_WINCE, MOZ_MEMORY_WINCE6, and MOZ_MEMORY_WINDOWS.
Reproducible: Always
| Assignee | ||
Comment 1•15 years ago
|
||
Updated•15 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
| Assignee | ||
Updated•15 years ago
|
Attachment #410120 -
Flags: review?(jasone)
Updated•15 years ago
|
Attachment #410120 -
Flags: review?(jasone) → review+
| Assignee | ||
Updated•15 years ago
|
Keywords: checkin-needed
Updated•15 years ago
|
Assignee: nobody → t.matsuu
Comment 2•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a3
You need to log in
before you can comment on or make changes to this bug.
Description
•