526418 - gloda plugin message indexing failures should not be fatal to the message

Status: NEW

(MailNews Core :: Database, defect)

Description

[Andrew Sutherland [:asuth] (he/him)]

As discussed on https://bugzilla.mozilla.org/show_bug.cgi?id=465618#c29, any failure of a gloda attribute provider will result in a message as being marked bad.  While fundattr.js and explattr.js failures must be treated as fatal for the message (resulting it being marked bad), other attribute providers should not receive the same treatment.

Comment 1

[Wayne Mery (:wsmwk)]

(In reply to Andrew Sutherland (:asuth) from comment #0)
> As discussed on https://bugzilla.mozilla.org/show_bug.cgi?id=465618#c29, any
> failure of a gloda attribute provider will result in a message as being
> marked bad.  While fundattr.js and explattr.js failures must be treated as
> fatal for the message (resulting it being marked bad), other attribute
> providers should not receive the same treatment.

As in, it permanently is marked bad and won't be indexed at all?
With current code, do we/did we encounter such messages in the wild?

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

Right, bad messages are invisible to gloda.  Right now I can't recall any buggy reasons we'd do this, but we did explicitly introduce an exception BadItemContentsError that we throw when 'From' contains 0 or more than 1 authors.

Certainly in development and early gloda we did run into various bad messages which caused the introduction of the bad message marking.  mxr on GLODA_BAD_MESSAGE_ID for related code and comments.