526453 - AIX Compilation error for 3.7a1pre source xpcom/io/nsFastLoadFile.cpp", line 884.13: 1540-0256 (S) A parameter of type "char *" cannot be initialized with an expression of type "PRUint8 *"

Status: RESOLVED DUPLICATE of bug 526176

(Firefox :: General, defect)

Description

[Shailen]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.4) Gecko/20091016 Firefox/3.5.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.4) Gecko/20091016 Firefox/3.5.4

While compiling Mozilla Firefox source for 3.7a1pre, getting
the below error.

"/home/firefox/mozilla-central/xpcom/io/nsFastLoadFile.cpp", line 884.13: 1540-0256 (S) A parameter of type "char *" cannot be initialized with an expression of type "PRUint8 *".
"/home/firefox/mozilla-central/xpcom/io/nsFastLoadFile.cpp", line 884.13: 1540-1205 (I) The error occurred while converting to parameter 1 of "madvise(caddr_t, size_t, int)".
gmake[1]: *** [nsFastLoadFile.o] Error 1


Reproducible: Always

Steps to Reproduce:
1. Build Mozilla Firefox 3.7a1pre build on AIX with Gnome RPMS of 64 bit
version.

2.
3.
Actual Results:  
Build fails with the above error.


Expected Results:  
No build failure

Comment 1

[Shailen]

Attachment: Patch V 1

The patch resolves the compilation error.

Comment 2

[(dormant account)]

Comment on attachment 410205 [details] [diff] [review]
Patch V 1

I don't believe caddr_t exists on linux/osx.

if aix is like solaris 
bug 526176  will fix this

Comment 3

[(dormant account)]

To clarify, instead of nesting more platform-specific defines, I'd rather rely on bug 526176 to rectify this situation.

Comment 4

[Shailen]

Attachment: Patch V 2

This behavior is similar to Solaris and hence attached the new patch

Comment 5

[(dormant account)]

Shailen, has bug 526176 fixed AIX compile?

Comment 6

[Shailen]

yes the revised patch (of bug 526176) fixes the AIX compile