User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:126.96.36.199) Gecko/20091016 Firefox/3.5.4 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:188.8.131.52) Gecko/20091016 Firefox/3.5.4 While compiling Mozilla Firefox source for 3.7a1pre, getting the below error. "/home/firefox/mozilla-central/xpcom/io/nsLocalFileUnix.h", line 97.13: 1540-0848 (S) The macro name "STAT" is already defined with a different definition. "/usr/include/sys/dir.h", line 288.9: 1540-0425 (I) "STAT" is defined on line 288 of "/usr/include/sys/dir.h". gmake: *** [nsLocalFileUnix.o] Error 1 Reproducible: Always Steps to Reproduce: 1. Build Mozilla Firefox 3.7a1pre build on AIX with Gnome RPMS of 64 bit version. 2. 3. Actual Results: Build fails with the above error. Expected Results: No build failure
Created attachment 410208 [details] [diff] [review] Patch V 1 The resolves the compilation error
patch doesn't apply
what errors are you getting ?
Comment on attachment 410208 [details] [diff] [review] Patch V 1 rs=me (rubber-stamp; no need for sr on this kind of AIX-only change in the future). /be
The patch doesn't apply for me.
Robert : Can you please let me know what errors you are getting while applying the patch ? May be I will look at the errors and provide an alternate patch ?
If you pull mozilla-central and apply the patch, you'll get the same errors I got.
[Shailen's patch used DOS line endings, which is why nobody could get it to apply, although git-apply --whitespace=fix would have worked.]
Comment on attachment 432355 [details] [diff] [review] recreated Shailen's patch For me trunk patch applied cleanly to both 1.9.2 and 1.9.1 branches too. The fix is needed for compilation of both 32- and 64bit on AIX. Risc: none, only codepath for #if defined AIX is changed.
Comment on attachment 432355 [details] [diff] [review] recreated Shailen's patch a=beltzner for 184.108.40.206 and 220.127.116.11