AIX Compilation error for 3.7a1pre source xpcom/io/nsLocalFileUnix.h", line 97.13: 1540-0848 (S) The macro name "STAT" is already defined with a different definition

RESOLVED FIXED in mozilla1.9.3a4

Status

()

Core
XPCOM
--
major
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: Shailen, Assigned: Shailen)

Tracking

({verified1.9.1, verified1.9.2})

Trunk
mozilla1.9.3a4
Other
AIX
verified1.9.1, verified1.9.2
Points:
---

Firefox Tracking Flags

(status1.9.2 .4-fixed, status1.9.1 .10-fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

8 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.4) Gecko/20091016 Firefox/3.5.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.4) Gecko/20091016 Firefox/3.5.4

While compiling Mozilla Firefox source for 3.7a1pre, getting
the below error.

"/home/firefox/mozilla-central/xpcom/io/nsLocalFileUnix.h", line 97.13: 1540-0848 (S) The macro name "STAT" is already defined with a different definition.
"/usr/include/sys/dir.h", line 288.9: 1540-0425 (I) "STAT" is defined on line 288 of "/usr/include/sys/dir.h".
gmake[1]: *** [nsLocalFileUnix.o] Error 1


Reproducible: Always

Steps to Reproduce:
1. Build Mozilla Firefox 3.7a1pre build on AIX with Gnome RPMS of 64 bit
version.

2.
3.
Actual Results:  
Build fails with the above error.



Expected Results:  
No build failure
(Assignee)

Updated

8 years ago
OS: Other → AIX
(Assignee)

Comment 1

8 years ago
Created attachment 410208 [details] [diff] [review]
Patch V 1

The resolves the compilation error
Attachment #410208 - Flags: review?(benjamin)
Attachment #410208 - Flags: review?(benjamin) → review+
(Assignee)

Updated

8 years ago
Attachment #410208 - Flags: superreview?(benjamin)
Attachment #410208 - Flags: superreview?(benjamin)
(Assignee)

Updated

8 years ago
Attachment #410208 - Flags: superreview?(shaver)
(Assignee)

Updated

8 years ago
Attachment #410208 - Flags: superreview?(shaver)
(Assignee)

Updated

8 years ago
Keywords: checkin-needed

Updated

8 years ago
Assignee: nobody → shailen.n.jain
patch doesn't apply
Keywords: checkin-needed
(Assignee)

Comment 3

8 years ago
what errors are you getting ?
(Assignee)

Updated

8 years ago
Attachment #410208 - Flags: superreview?(brendan)
Comment on attachment 410208 [details] [diff] [review]
Patch V 1

rs=me (rubber-stamp; no need for sr on this kind of AIX-only change in the future).

/be
Attachment #410208 - Flags: superreview?(brendan) → superreview+
(Assignee)

Updated

8 years ago
Keywords: checkin-needed
The patch doesn't apply for me.
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
(Assignee)

Comment 6

8 years ago
Robert :

 Can you please let me know what errors you are getting while applying the patch ?
May be I will look at the errors and provide an alternate patch ?
If you pull mozilla-central and apply the patch, you'll get the same errors I got.

Updated

8 years ago
Component: General → XPCOM
Product: Firefox → Core
QA Contact: general → xpcom
Version: unspecified → Trunk

Updated

8 years ago
Attachment #410208 - Attachment is obsolete: true

Updated

8 years ago
Keywords: checkin-needed
Created attachment 432355 [details] [diff] [review]
recreated Shailen's patch
Attachment #410208 - Attachment is obsolete: false
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
http://hg.mozilla.org/mozilla-central/rev/9b7c5d7fcbda
[Shailen's patch used DOS line endings, which is why nobody could get it to apply, although git-apply --whitespace=fix would have worked.]
Comment on attachment 432355 [details] [diff] [review]
recreated Shailen's patch

For me trunk patch applied cleanly to both 1.9.2 and 1.9.1 branches too.

The fix is needed for compilation of both 32- and 64bit on AIX.
Risc: none, only codepath for #if defined AIX is changed.
Attachment #432355 - Flags: approval1.9.2.3?
Attachment #432355 - Flags: approval1.9.1.10?
Comment on attachment 432355 [details] [diff] [review]
recreated Shailen's patch

a=beltzner for 1.9.2.3 and 1.9.1.10
Attachment #432355 - Flags: approval1.9.2.3?
Attachment #432355 - Flags: approval1.9.2.3+
Attachment #432355 - Flags: approval1.9.1.10?
Attachment #432355 - Flags: approval1.9.1.10+
Keywords: checkin-needed
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/5a51c5876cb3
status1.9.2: --- → .4-fixed
Target Milestone: --- → mozilla1.9.3a4
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/9c4e273fb291
status1.9.1: --- → .10-fixed
Keywords: checkin-needed
Keywords: verified1.9.1
Keywords: verified1.9.2
You need to log in before you can comment on or make changes to this bug.