getAllLogins, getAllDisabledHosts and getAllEncryptedLogins count out params should be optional

RESOLVED FIXED in mozilla1.9.3a1

Status

()

Toolkit
Password Manager
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

Trunk
mozilla1.9.3a1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Created attachment 410273 [details] [diff] [review]
patch
Attachment #410273 - Flags: review?(dolske)
Comment on attachment 410273 [details] [diff] [review]
patch

r=me on the pwmgr related bits.
There's also findLogins() and searchLogins() that return arrays, does the [optional] annotation work there too? If so, should do those too.
Attachment #410273 - Flags: review?(dolske) → review+
(Assignee)

Comment 2

8 years ago
It won't work for findLogins and searchLogins without making count the last param, i.e. changing the API.
(Assignee)

Comment 3

8 years ago
http://hg.mozilla.org/mozilla-central/rev/b61609ee5d06
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
You need to log in before you can comment on or make changes to this bug.