526593 - [mozmill] Update testLocationBarSearches.js to fix failures

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Patch v1

The following test under firefox/testAwesomeBar/testLocationBarSearches.js has to be updated to fix the following problems:

* There was an update to Mozmill which changed the way we open web pages. When you want to test the location bar you have to user controller.type and controller.keypress.

* The first test with 'oau45rtdgsh34nf' as search term fails again thanks to the indexing of testcases on brasstacks. Adding another character works fine.

Tracy, are you ok with these changes?

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Tracy, the last test what did it test in detail? The element cannot be found whether which platform I test on. :/

Comment 2

[Tracy Walker [:tracy]]

It's checking for the string 'lotr' in the blue strip below the google search bar but above the list ove results : as in  Results 1 - 10 of about 5,060,000 for lotr. (0.43 seconds) 

changes are fine by me. won;t the random string just get indexed again and again?

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #2)
> It's checking for the string 'lotr' in the blue strip below the google search
> bar but above the list ove results : as in  Results 1 - 10 of about 5,060,000
> for lotr. (0.43 seconds)

I do not have this blue bar. Or at least there is no "lotr" shown. The only thing I can see there is "Web". That's all. So should we just assume that results have been found?

> changes are fine by me. won;t the random string just get indexed again and
> again?

I don't think that hg gets indexed. I just wonder how we should handle the litmus test. By the way that test needs an update too so that it reflects this test. Can you please do that Tracy?

Comment 4

[Tracy Walker [:tracy]]

Attachment: lotrgoogleresults

the attachments shows what I get from a google results page.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

So you mean the sponsored link, right? Looks like that it is only shown in a couple of regions. Shall I go with checking if results have been found?

Comment 6

[Tracy Walker [:tracy]]

It's not checking a sponsored link.  The test looks for the lotr right after "about 5,070,000 for " <lotr>  Is that data really not provided for you in de?  That's odd.  Seems like a Google bragging point. (hey look, we found over 5 million results in an eighth of a second)

Checking for something within the results list is too flaky. I went through a few iterations attempting to do just that with unreliable results.  You can't guarantee what will be in the results list from region to region much less from day to day.  If you can figure out how to determine if there are just results present, go for it.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Patch v2

Thanks Tracy. So it turns out that the problem is simply the wrong usage of assertValue instead of assertText. With the change it works fine.

Comment 8

[Aakash Desai [:aakashd]]

Comment on attachment 410767 [details] [diff] [review]
Patch v2

Looks good on the cosmetic changes. This works fine on Namoroka and Firefox 3.5 over XP and OSX.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/251f763d201f
http://hg.mozilla.org/qa/mozmill-tests/rev/5fb8b1ea3361

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Mass move of Mozmill Test related project bugs to newly created components. You can filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.