Closed
Bug 526633
Opened 16 years ago
Closed 16 years ago
unnecessary code for NS_ACTIVATE/NS_DEACTIVATE in nsObjectFrame::HandleEvent()
Categories
(Core Graveyard :: Plug-ins, defect)
Core Graveyard
Plug-ins
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: karlt, Assigned: jaas)
Details
Attachments
(1 file)
|
1.14 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
nsObjectFrame::HandleEvent() has code (for non XP_WIN platforms) to handle
NS_ACTIVATE/NS_DEACTIVATE.
http://hg.mozilla.org/mozilla-central/annotate/3d5cde53f929/layout/generic/nsObjectFrame.cpp#l1849
which is used (only for Mac) in ProcessEvent() when the event has a .nativeMsg:
http://hg.mozilla.org/mozilla-central/annotate/3d5cde53f929/layout/generic/nsObjectFrame.cpp#l4224
However, these events do not have a .nativeMsg with Cocoa (or GTK).
http://hg.mozilla.org/mozilla-central/annotate/3d5cde53f929/widget/src/cocoa/nsChildView.mm#l2414
I assume the code on nsObjectFrame::HandleEvent() is unnecessary (if it ever
did anything) because NS_FOCUS_CONTENT and NS_BLUR_CONTENT notify the plugin
of focus changes:
http://hg.mozilla.org/mozilla-central/annotate/3d5cde53f929/layout/generic/nsObjectFrame.cpp#l4160
Attachment #411356 -
Flags: review?(roc)
Attachment #411356 -
Flags: review?(roc) → review+
pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/f746608c8655
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Updated•4 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•