Closed Bug 526663 Opened 11 years ago Closed 10 years ago

[Win7] Firefox shortcut icon remains in taskbar after uninstalling application

Categories

(Firefox :: Installer, defect)

x86
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: marcia, Assigned: jimm)

References

Details

Attachments

(4 files, 1 obsolete file)

Seen while running the latest 1.9.2 nightly.

STR:
1. Install Namoroka build in the default directory.
2. Pin the app to the taskbar.
2. Run the uninstaller.

See the attached screenshot. We leave an icon behind in the taskbar after the uninstaller is run.

I tried the same STR using Google Chrome and that app did not leave anything behind.
Attachment #410401 - Attachment description: Screenshot of shortcut icon → Screenshot of shortcut window
Summary: Firefox shortcut icon remains in taskbar after uninstalling application → [Win7] Firefox shortcut icon remains in taskbar after uninstalling application
I'm not sure if we can delete this, since it was based on a user action.
Blocks: win7support
Component: Installer: XPInstall Engine → Installer
Product: Core → Firefox
QA Contact: xpi-engine → installer
Version: 1.9.2 Branch → Trunk
We *might* be able to since there are a few hacks out there for working around the intentional lack of ability for installers to add / remove the taskbar shortcuts.
> Any shortcut installed by an application might have been subsequently pinned by the user, and there is no way for an application to know this. Therefore, we recommend that, during uninstallation, all applications call IStartMenuPinnedList::RemoveFromList  on each shortcut they installed.

http://msdn.microsoft.com/en-us/library/bb774817.aspx
(In reply to comment #4)
> > Any shortcut installed by an application might have been subsequently pinned by the user, and there is no way for an application to know this. Therefore, we recommend that, during uninstallation, all applications call IStartMenuPinnedList::RemoveFromList  on each shortcut they installed.
> 
> http://msdn.microsoft.com/en-us/library/bb774817.aspx

Woot! We can add that to the uninstall. Thanks James!
OS: Windows NT → Windows 7
Attached patch patch v.1 (obsolete) — Splinter Review
Assignee: nobody → jmathies
Depends on: 521141
Attached patch patch v.2Splinter Review
Attachment #442915 - Attachment is obsolete: true
Attachment #443362 - Flags: review?(robert.bugzilla)
Attachment #443362 - Flags: review?(robert.bugzilla) → review+
       ShellLink::GetShortCutTarget "$QUICKLAUNCH\$R8"
       Pop $R5
       StrCmp "$INSTDIR\${FileMainEXE}" "$R5" +1 -7
+      ApplicationID::UninstallPinnedItem "$QUICKLAUNCH\$R8"
       Delete "$QUICKLAUNCH\$R8"

Rob, should I add pops after all of these UninstallPinnedItem calls?
Definitely if they change the registers from what they were before calling the macro.
Added Pop's to remove the result of ApplicationID::UninstallPinnedItem from the stack.
http://hg.mozilla.org/mozilla-central/rev/aba944ea85dd
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.