[Win7] Firefox shortcut icon remains in taskbar after uninstalling application

RESOLVED FIXED

Status

()

Firefox
Installer
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: marcia, Assigned: jimm)

Tracking

(Blocks: 1 bug)

Trunk
x86
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments, 1 obsolete attachment)

(Reporter)

Description

8 years ago
Created attachment 410401 [details]
Screenshot of shortcut window

Seen while running the latest 1.9.2 nightly.

STR:
1. Install Namoroka build in the default directory.
2. Pin the app to the taskbar.
2. Run the uninstaller.

See the attached screenshot. We leave an icon behind in the taskbar after the uninstaller is run.

I tried the same STR using Google Chrome and that app did not leave anything behind.
(Reporter)

Updated

8 years ago
Attachment #410401 - Attachment description: Screenshot of shortcut icon → Screenshot of shortcut window
(Reporter)

Comment 1

8 years ago
Created attachment 410402 [details]
Screenshot of shortcut icon
(Reporter)

Updated

8 years ago
Summary: Firefox shortcut icon remains in taskbar after uninstalling application → [Win7] Firefox shortcut icon remains in taskbar after uninstalling application
(Assignee)

Comment 2

8 years ago
I'm not sure if we can delete this, since it was based on a user action.
(Assignee)

Updated

8 years ago
Blocks: 474052
(Assignee)

Updated

8 years ago
Component: Installer: XPInstall Engine → Installer
Product: Core → Firefox
QA Contact: xpi-engine → installer
Version: 1.9.2 Branch → Trunk
We *might* be able to since there are a few hacks out there for working around the intentional lack of ability for installers to add / remove the taskbar shortcuts.

Comment 4

8 years ago
> Any shortcut installed by an application might have been subsequently pinned by the user, and there is no way for an application to know this. Therefore, we recommend that, during uninstallation, all applications call IStartMenuPinnedList::RemoveFromList  on each shortcut they installed.

http://msdn.microsoft.com/en-us/library/bb774817.aspx
(Assignee)

Comment 5

8 years ago
(In reply to comment #4)
> > Any shortcut installed by an application might have been subsequently pinned by the user, and there is no way for an application to know this. Therefore, we recommend that, during uninstallation, all applications call IStartMenuPinnedList::RemoveFromList  on each shortcut they installed.
> 
> http://msdn.microsoft.com/en-us/library/bb774817.aspx

Woot! We can add that to the uninstall. Thanks James!
(Assignee)

Updated

8 years ago
OS: Windows NT → Windows 7
(Assignee)

Comment 6

8 years ago
Created attachment 442915 [details] [diff] [review]
patch v.1
Assignee: nobody → jmathies
(Assignee)

Updated

8 years ago
Depends on: 521141
(Assignee)

Comment 7

8 years ago
Created attachment 443362 [details] [diff] [review]
patch v.2
Attachment #442915 - Attachment is obsolete: true
Attachment #443362 - Flags: review?(robert.bugzilla)
Attachment #443362 - Flags: review?(robert.bugzilla) → review+
(Assignee)

Comment 8

8 years ago
       ShellLink::GetShortCutTarget "$QUICKLAUNCH\$R8"
       Pop $R5
       StrCmp "$INSTDIR\${FileMainEXE}" "$R5" +1 -7
+      ApplicationID::UninstallPinnedItem "$QUICKLAUNCH\$R8"
       Delete "$QUICKLAUNCH\$R8"

Rob, should I add pops after all of these UninstallPinnedItem calls?
Definitely if they change the registers from what they were before calling the macro.
(Assignee)

Comment 10

8 years ago
Created attachment 445427 [details] [diff] [review]
updated patch v.2

Added Pop's to remove the result of ApplicationID::UninstallPinnedItem from the stack.
(Assignee)

Comment 11

8 years ago
http://hg.mozilla.org/mozilla-central/rev/aba944ea85dd
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.