52680 - Classic skin should use CSS system fonts

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect, P2)

Description

[Akkana Peck]

The classic skin still isn't using the CSS system fonts for menus and other
text.  In the classic skin, I see an impossibly small font, whereas gtk apps
come up with a much larger one.

Bryner suggested the following patch to themes/classic/global/win/global.css:

-	/* font-family         : sans-serif;
-      font                : dialog; */
+      font-family         : sans-serif;
+      font                : dialog;

and adds "so i don't see any way that system fonts are happening on win32"

and indeed his patch fixes the problem.

Comment 1

[Akkana Peck]

Nominating for beta3 since the fix is trivial, it's in hand, and it's important
both for the look of the classic skin and for accessiblity (even if we don't
care about visually impaired people being able to use modern, let's at least
give them one skin they can use).

Comment 2

[Blake Ross]

-> themes

Comment 3

[Phil Peterson]

Don to look into this since he thinks he already checked that code in two months 
ago.

Comment 4

[don]

Taking this from Ben for investigation ...

Comment 5

[don]

OK, Ben has the fix for this in his tree.  Marking "nsbeta3+" ...

Comment 6

[don]

Doh!  Forgot to re-assign to Ben ...

Comment 7

[don]

Let's do this in RTM and not beta 3.

Comment 8

[Ben Goodger (use ben at mozilla dot org for email)]

according to my up to date tree, this has already been fixed. 

Comment 9

[Patty Mac]

Verified ok on linux (2000-10-10-10-MN6).