526821 - 1.4rc1 Undo a Personas Change cause Error in the Error Console

Status: VERIFIED FIXED

(Mozilla Labs Graveyard :: Personas Plus, defect)

Description

[Carsten Book [:Tomcat]]

Steps to reproduce:
-> install the Personas 1.4rc1 
-> change personas 

-> Check the Error Console::

Reproduced on Vista and Mac so far

Error: Could not write binary file footer.png
Source File: file:///C:/Users/mozilla/AppData/Roaming/Mozilla/Firefox/Profiles/l6oor13e.default/extensions/[e-mail]/modules/service.js
Line: 1263

Error: Could not write binary file header.png
Source File: file:///C:/Users/mozilla/AppData/Roaming/Mozilla/Firefox/Profiles/l6oor13e.default/extensions/[e-mail]/modules/service.js
Line: 1263

Comment 1

[Jose E. Bolanos]

I'm following the steps mentioned and the files seem to be saved correctly, with no errors reported. Were there any other special conditions when this happened perhaps?

Comment 2

[Jose E. Bolanos]

Got it. This happens when the "Undo" button is pressed too quickly, before the undone persona images are saved.

Comment 3

[Suneel]

Can't tell if this is an edge-case. Regardless, Jose, do you have an ETD for a fix?

Comment 4

[Jose E. Bolanos]

This requires a very minor fix, and will be ready by Monday morning (9th).

Comment 5

[Jose E. Bolanos]

The changes have been uploaded to the rep., changeset 68dd3b327e9f.

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Awesome, thanks!

Jose: once you commit a fix, make sure you resolve the bug, so we can distinguish bugs that are still outstanding from those that have already been fixed.

Comment 7

[Carsten Book [:Tomcat]]

verified on 1.4rc2 , thanks Jose !