Last Comment Bug 526864 - unused parameter aFrameToUse in imgContainer::DoComposite
: unused parameter aFrameToUse in imgContainer::DoComposite
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: ImageLib (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: mozilla10
Assigned To: Benoit Girard (:BenWa)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-11-05 13:43 PST by Joe Drew (not getting mail)
Modified: 2011-10-09 07:37 PDT (History)
2 users (show)
Ms2ger: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
remove aFrameToUse (6.06 KB, patch)
2009-11-05 13:43 PST, Joe Drew (not getting mail)
bobbyholley: review+
Details | Diff | Review
remove aFrameToUse fix rot (6.20 KB, patch)
2011-10-07 21:07 PDT, Benoit Girard (:BenWa)
bobbyholley: review+
Details | Diff | Review

Description Joe Drew (not getting mail) 2009-11-05 13:43:41 PST
Created attachment 410600 [details] [diff] [review]
remove aFrameToUse

After bug 753 landed, we stopped needing to use the result of what DoComposite set aFrameToUse to, but never removed it as a parameter. This patch does that.
Comment 1 Bobby Holley (busy) 2009-11-23 14:05:40 PST
Comment on attachment 410600 [details] [diff] [review]
remove aFrameToUse

r+
Comment 2 Benoit Girard (:BenWa) 2011-10-07 21:07:18 PDT
Created attachment 565704 [details] [diff] [review]
remove aFrameToUse fix rot

Fix bitrot but still asking for review to make sure we still want this change.
Comment 3 Bobby Holley (busy) 2011-10-07 22:38:29 PDT
Comment on attachment 565704 [details] [diff] [review]
remove aFrameToUse fix rot

it's an internal API, and the value is only ever written to. r+!

Note You need to log in before you can comment on or make changes to this bug.