Closed
Bug 526868
Opened 15 years ago
Closed 15 years ago
Drop the dependency on GLIBCXX_3.4.9 by hacking Chromium to not include or use std::ostream
Categories
(Core :: IPC, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: benjamin, Assigned: benjamin)
References
Details
Attachments
(1 file)
|
9.61 KB,
patch
|
cjones
:
review+
|
Details | Diff | Splinter Review |
The dependency on GLIBCXX_3.4.9 in e10s builds is introduced by Chromium builds using ostream, and g++ introduced a new binary interface for ostream in GCC 4.3 (at least from what I can tell). I have fixed this by hacking out the guts of logging.h/cc and replacing all the logging with an NSPR sorta-workalike. There are a couple issues still: more serious errors, and error-checking which chromium previously was running in release builds, is only enabled in debug builds. This is probably fixable, perhaps with a calls to NS_DebugBreak. In any case I'd like to get this in as-is in order to turn the Linux tree not-orange, because that's causing us so much grief, and will cause us even more grief with Talos.
|
Assignee | |
Comment 1•15 years ago
|
||
Attachment #410606 -
Flags: review?(jones.chris.g)
|
||
Updated•15 years ago
|
Attachment #410606 -
Attachment description: Remove dependencies on <bhearsum> huh, i'm surprised it didn't fix packaged tests * whimboo is now known as whimboo|afk * karl (karl@moz-7792EA5F.jetstream.xtra.co.nz) hasostream from chromium, rev. 1 → Remove dependencies on ostream from chromium, rev. 1
|
||
Updated•15 years ago
|
Attachment #410606 -
Flags: review?(jones.chris.g) → review+
|
|
Assignee | |
Comment 2•15 years ago
|
||
FWIW, this went though several revisions after landing, and I ended up with a version which spews warnings, assertions, and aborts using NS_DebugBreak, and properly distinguishes between debug-only and all-config checks. http://hg.mozilla.org/projects/electrolysis/rev/c6c2026ba4cf http://hg.mozilla.org/projects/electrolysis/rev/48f43197ae75 http://hg.mozilla.org/projects/electrolysis/rev/ef1c7ba3103b http://hg.mozilla.org/projects/electrolysis/rev/88f0199e8284 http://hg.mozilla.org/projects/electrolysis/rev/30f7096ee4b7 http://hg.mozilla.org/projects/electrolysis/rev/a03c00114c66
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Version: unspecified → Other Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•