526989 - getEngines, getVisibleEngines and getDefaultEngines engineCount out params should be optional

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 410770 [details] [diff] [review]
patch

>diff --git a/toolkit/components/search/nsSearchService.js b/toolkit/components/search/nsSearchService.js

>+    if (aCount)
>+      aCount.value = engines.length;

Are these changes actually needed? I figured xpconnect still needed the count and therefore always passed in this argument... or are these also called directly?

Comment 2

[Dão Gottwald [:dao]]

looks like they aren't needed.

http://hg.mozilla.org/mozilla-central/rev/71f262fe12a5