Enable JavaScript jsreftests on mozilla-central unittests



9 years ago
6 years ago


(Reporter: bc, Assigned: coop)


Firefox Tracking Flags

(Not tracked)



(1 attachment, 1 obsolete attachment)



9 years ago
+++ This bug was initially created as a clone of Bug #519213 +++

Please enable the JavaScript jsreftests on mozilla-central unit test machines for all three build types including debug.
Assignee: nobody → ccooper
Priority: P4 → P3
Priority: P3 → P2
Created attachment 411743 [details] [diff] [review]
Enable jsreftests on mozilla-central
Attachment #411743 - Flags: review?(nthomas)
Attachment #411743 - Flags: review?(nthomas) → review+

Comment 2

9 years ago
This will be really great to have up and running.

It will probably cause some initial orange. Can you give me some heads up when you might deploy it so I can be sure to be available? We might also want to do it during a quiet time (relatively) so any initial orange can be stamped out quickly without interfering with everyone.
Bob: the most "quiet" times are generally early morning. I could push this live either tomorrow (Thursday) or Friday AM EST if that works for you.
After this suite is deployed, and green, on mozilla-central, should we then enable this unittest suite on other branches? (f.e., mozilla-1.9.2, places, electrolysis, tracemonkey, TryServer)

Also, approx how long does this take to run?

Comment 5

9 years ago
It is already running on tracemonkey although it currently is only running with opt builds.

I expect opt to take around 10 minutes, and debug around 20 minutes. This agrees with the times on tracemonkey tests.

We will want this on mozilla-1.9.2 eventually, but the relevant code hasn't landed there yet.

It would be helpful for the developers if the TryServer ran the tests (opt and debug if possible) for those branches where jsreftests has landed, currently mozilla-central and tracemonkey.

I'm not familiar with places, but I don't think we will need it there.

If the normal reftests and crashtests run on electrolysis and electrolysis periodically is synced with mozilla-central, it may be desirable to run them there, but I don't think so. bsmedberg and jgriffin will know more about feasibility and desirability. 

I don't think we will want it on 1.9.1 due to the number of prerequisites that haven't landed there.
This is live now, and I've triggered a bunch of everythingelse unittests on mozilla-central.
Created attachment 411977 [details] [diff] [review]
Enable jsreftests on mozilla-central, v2
Attachment #411743 - Attachment is obsolete: true
Attachment #411977 - Flags: review?(catlee)
Attachment #411977 - Flags: review?(catlee) → review+
Seems to be working now. I already see some passing results for OS X mozilla-central test everythingelse and WINNT mozilla-central test everythingelse, and I've triggered rebuilds for all the others.
We should enable these on e10s, after the next merge from mozilla-central.
One failed jsreftest so far on the WINNT debug everythingelse builder, but other platforms seem fine.



REFTEST TEST-UNEXPECTED-FAIL | file:///e:/builds/moz2_slave/mozilla-central-win32-debug-unittest-everythingelse/build/jsreftest/tests/jsreftest.html?test=js1_5/extensions/regress-371636.js | Numeric sort performance Expected value '(tint/tstr < 3)=true', Actual value '(tint/tstr < 3)=false'  item 1

bc: do you want to track that failure in a separate bug, or just reassign this bug to yourself to work on it?

Comment 13

9 years ago
coop, I'll track that in a separate bug. thanks!


9 years ago
Whiteboard: orange


9 years ago
Whiteboard: orange
Last Resolved: 9 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.