527105 - Hovering over a taskbar preview causes the product name in the title bar to disappear

Status: VERIFIED FIXED

(Firefox :: Shell Integration, defect)

Description

[u88484]

+++ This bug was initially created as a clone of Bug #527103 +++

When I hover over a taskbar preview the product name in the title bar disappears

STR: 
1) Open two or more tabs
2) Move mouse down to the taskbar and hover over the Minefield icon so that the tab previews show
4) Move mouse up to any tab in the preview while watching the Minefield title bar

Actual Result: The product name in the title bar disappears
Expected Result: The product name in the title bar doesn't disappear

When moving the mouse off the preview and back onto the taskbar, the pdocut name reappears.

Rob Arnold asked me to file this bug in his comment of bug 521954 comment 14.

Rob also stated this in the aforementioned comment:
"this is the .title property of the
nsITaskbarTabPreview object that you're seeing during the preview. We control
this. File a separate bug on this (not sure if I think it should be fixed or
not - that's for someone else to decide)."

Comment 1

[Rob Arnold [:robarnold]]

Attachment: calculate preview title via tabbrowser.xml

This patch modifies the preview-per-tab code to pull the title from the <tabbrowser>. tabbrowser.xml's modification is to split out the computation of the title from the process of actually updating it.

Comment 2

[Rob Arnold [:robarnold]]

Comment on attachment 422047 [details] [diff] [review]
calculate preview title via tabbrowser.xml

Adding Dão for review of the tabbrowser.xml changes.

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 422047 [details] [diff] [review]
calculate preview title via tabbrowser.xml

>-      <method name="updateTitlebar">
>+      <method name="computeTitlebarText">
>+        <parameter name="aBrowser"/>

I don't like this name and would suggest getWindowTitleForBrowser instead. In any case, you should get this new method superreviewed, e.g. by mconnor.

>+  updateTitle: function () {
>+    this.preview.title = this.win.tabbrowser.computeTitlebarText(this.linkedBrowser);
>+  },

I would expect this.preview.tooltip to get the same value.

Comment 4

[Rob Arnold [:robarnold]]

Attachment: calculate preview title via tabbrowser.xml (v1.1)

Comment 5

[Rob Arnold [:robarnold]]

Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/5f33e4fbf65d

Comment 6

[u88484]

Verified fixed using hourly build Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a3pre) Gecko/20100309 Minefield/3.7a3pre ID:20100309211739

Comment 7

[Rob Arnold [:robarnold]]

Comment on attachment 422095 [details] [diff] [review]
calculate preview title via tabbrowser.xml (v1.1)

Requesting 1.9.2 approval. This adds a new API to tabbrowser.xml but this is to allow some trivial new functionality (namely the ability to get the title for a tab).

Comment 8

[LegNeato]

Comment on attachment 422095 [details] [diff] [review]
calculate preview title via tabbrowser.xml (v1.1)

a=LegNeato for 1.9.2.5. Please ONLY land this on mozilla-1.9.2 default, as we are still working on 1.9.2.4 on the relbranch

Comment 9

[Marco Bonardo [:mak]]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/c655a68ae741