Last Comment Bug 527109 - handle non '/' hierarchy delimiters during first time xlist special folder discovery
: handle non '/' hierarchy delimiters during first time xlist special folder di...
Status: RESOLVED FIXED
: fixed-seamonkey2.0.1
Product: MailNews Core
Classification: Components
Component: Networking: IMAP (show other bugs)
: Trunk
: x86 Windows NT
: -- normal (vote)
: Thunderbird 3.0rc1
Assigned To: David :Bienvenu
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-11-06 13:44 PST by David :Bienvenu
Modified: 2009-12-13 06:05 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
proposed fix (1.16 KB, patch)
2009-11-06 13:44 PST, David :Bienvenu
dmose: review+
dmose: superreview+
dmose: approval‑thunderbird3+
Details | Diff | Review

Description David :Bienvenu 2009-11-06 13:44:01 PST
Created attachment 410861 [details] [diff] [review]
proposed fix

If an imap server supports xlist but doesn't use '/' as the hierarchy delimiter (e.g., Cyrus, which is used by fastmail), on first connection, our second xlist command doesn't use the correct hierarchy delimiter, so special folders aren't recognized until a restart, which isn't a nice user experience.

This patch is very simple, and only affects imap servers that support xlist (gmail and dovecot currently, cyrus/fastmail soon).

I'd love to have this make 3.0 so we work well with fastmail.
Comment 1 Dan Mosedale (:dmose) 2009-11-06 14:36:42 PST
Comment on attachment 410861 [details] [diff] [review]
proposed fix

r+sr+a=dmose.  If it makes sense, add an XXX comment that when we're less risk-averse we could make that setter call not be conditional on Inbox, so that m_runningUrl would reflect reality better and perhaps prevent future bugs.
Comment 2 David :Bienvenu 2009-11-06 14:57:47 PST
fixed on trunk and branch, thx!
Comment 3 Bron Gondwana 2009-11-06 22:31:31 PST
Confirmed works with my testing XLIST branch at FastMail - will push this back to Cyrus, so it should be useful for other Cyrus sites before long too.

I suspect there will be some debate about hard coded config file entries versus cyradm settable annotations before it goes mainstream at the server end though...

Bron.

Note You need to log in before you can comment on or make changes to this bug.