527182 - crash entering login info on twitter

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect)

Description

[Doug Turner (:dougt)]

i have a saved username and passwords for twitter.  when i try to login, i click in the upper right of twitters page.  it does some dhtml thing which shows two edit boxed.  both are filled out. i see my password in CLEAR text.

blassey, can you reproduce?

Comment 1

[Doug Turner (:dougt)]

beta blocker?

Comment 2

[Doug Turner (:dougt)]

oh.  the timer is held onto after the object is finished.



however, i am still seeing, this:

###!!! ASSERTION: QueryInterface needed: 'query_result.get() == mRawPtr', file ../../dist/include/nsCOMPtr.h, line 521


Brad, any idea?

Comment 3

[Doug Turner (:dougt)]

Attachment: kill the timer

Comment 4

[Doug Turner (:dougt)]

http://hg.mozilla.org/mozilla-central/rev/05ab1cbc361f

Comment 5

[Doug Turner (:dougt)]

i pushed this to 1.9.2 so that it will be in for beta 5.

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/3f96eaed7fdf

Comment 6

[timeless]

comment 2 typically means the object held by nsCOMPtr<> has a broken QI method which doesn't list something available from the c++ class vtable (and that something is the nsISomeThing type specified by nsCOMPtr<nsISomeThing>.

Comment 7

[Doug Turner (:dougt)]

@timeless, i think it is unrelated to this particular bug.

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 410976 [details] [diff] [review]
kill the timer

a192=beltzner, post-hoc, with a bit of a scowl. Let's not do unapproved landings on a restricted tree, mmkay?

Comment 9

[Damon Sicore (:damons)]

Where's a test for this?

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #9)
> Where's a test for this?

This is currently not testable on any desktop. We can get a browser-chrome test ready for maemo and winmo.

Comment 11

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: test case

Comment 12

[Al Billings [:abillings - ex-MoCo]]

This does not crash in the 11/9 morning build (aka Beta 5) build on my n900. I saved a password, logged out, and logged back in with it remembering my saved password on twitter. Anything else to do here?

Comment 13

[Brad Lassey [:blassey] (use needinfo?)]

nope, that should reproduce the bug on an 11/6 build.  You could also try the test case I attached if you want to be thorough.  It will crash you without the dependency on having a saved password.

Comment 14

[Al Billings [:abillings - ex-MoCo]]

Testcase doesn't crash in the same build either.

Comment 15

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch for broken QI

(In reply to comment #6)
> comment 2 typically means the object held by nsCOMPtr<> has a broken QI method
> which doesn't list something available from the c++ class vtable (and that
> something is the nsISomeThing type specified by nsCOMPtr<nsISomeThing>.

yup, this fixes the broken QI impl

Comment 16

[timeless]

Comment on attachment 411720 [details] [diff] [review]
patch for broken QI

a better checkin comment would be great :)

Comment 17

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/mozilla-central/rev/ad2e8d859c2e

Comment 18

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/releases/mozilla-1.9.2/rev/29b771a100b8

Comment 19

[Samuel Sidler (old account; do not CC)]

These bugs landed after b4 was cut. Moving flag out.

Comment 20

[Samuel Sidler (old account; do not CC)]

(In reply to comment #19)
> These bugs landed after b4 was cut. Moving flag out.

I lied about this bug.

Comment 21

[:Gavin Sharp [email: [e-mail]]]

No you didn't, we actually built b5 from af0e2b9566cc :)